FreeTubeApp / FreeTube

An Open Source YouTube app for privacy
https://freetubeapp.io/
GNU Affero General Public License v3.0
12.35k stars 754 forks source link

[Bug]: `Remove All Subscriptions / Profiles` in Privacy Settings should be removed when `Hide Unsubscribe button` is enabled #3503

Closed efb4f5ff-1298-471a-8973-3d47447115dc closed 1 year ago

efb4f5ff-1298-471a-8973-3d47447115dc commented 1 year ago

Guidelines

Describe the bug

Basically the same request as #3501

  1. Enable Hide unsubscribe button in the Parental Control Settings
  2. Scroll up and Open the Privacy Settings tab
  3. See that the Remove All Subscriptions / Profiles is available

This button does the same as unsubscribing to a channel but in a way more destructive way.

https://user-images.githubusercontent.com/73130443/236694416-ed631977-41e7-4ca9-a5f8-d446375f38f9.mp4

Expected Behavior

Hide Remove All Subscriptions / Profiles in Privacy Settings if Hide unsubscribe button in the Parental Control Settings is enabled

Issue Labels

inconsistent behavior

FreeTube Version

https://github.com/FreeTubeApp/FreeTube/commit/2345752308c7ae35b7acbd45297b57599a14a0c3

Operating System Version

Win10 22H2

Installation Method

.exe

Primary API used

Local API

Last Known Working FreeTube Version (If Any)

No response

Additional Information

No response

Nightly Build

github-actions[bot] commented 1 year ago

This issue is stale because it has been open 28 days with no activity. Remove stale label or comment or this will be closed in 7 days.

Rikthepixel commented 1 year ago

Sounds like a fair request/bug. Since it is in bug reports board, I thought I'd implement it.

Solved it in pull request: #3693

efb4f5ff-1298-471a-8973-3d47447115dc commented 1 year ago

https://github.com/FreeTubeApp/FreeTube/pull/3693#issuecomment-1609020704