FreeTubeApp / FreeTube

An Open Source YouTube app for privacy
https://freetubeapp.io/
GNU Affero General Public License v3.0
13.15k stars 817 forks source link

[Feature Request]: Move "Region for Trending" to the Trending pages. #3636

Closed aleksejrs closed 1 year ago

aleksejrs commented 1 year ago

Guidelines

Problem Description

The "Region for Trending" setting affects only the tabs of the Trending page. It is interesting to switch between regions, and going to the Settings page takes multiple steps. Not all values of the setting work.

Proposed Solution

Move the UI to change the setting to near the title of the "Trending" page.

Alternatives Considered

Copy it there instead of moving.

Issue Labels

ease of use improvement, improvement to existing feature

Additional Information

v0.18.0-nightly-3004 Beta

efb4f5ff-1298-471a-8973-3d47447115dc commented 1 year ago

So u want the setting to be in the trending tab?

aleksejrs commented 1 year ago

Yes. Maybe to the right of the word "Trending" that is the page header, so it does not take space.

efb4f5ff-1298-471a-8973-3d47447115dc commented 1 year ago

I understand why u would like that but we would like to have all the settings in one menu. Lets say we implement this but for other components within FT. The user has now multiple locations to go to if they want to change something.

So again I understand that it is a logical decision to move it over to trending but IMO i think its better to keep it this way for the sake of keeping everything together in one menu and make the user go to one page where they can change everything within FT

aleksejrs commented 1 year ago

The user has now multiple locations to go to if they want to change something.

Do you think users are more stupid than lazy? Changing the setting that only affects one page and can be used by the same user multiple times a day takes 3 or 4 extra clicks because of a foolish consistency. If the setting is on the same page, it is easy to notice and the user who uses Trending does not have to go anywhere. Profile Select is not in Settings but available from a button everywhere, because it is useful everywhere.

The only argument I can see for some users is that Locale Preference, Region for Trending and Current Invidious Instance are vaguely related. But that relationship is very weak, especially for users who are not confused to death by the words "API", "Backend" and "Invidious instance" on the page. :) Russian translation for those options is strange and inconsistent, but I don't know what users who can't read English and are unfamiliar with programming expect. I guess it was translated by two of them.

o-data commented 1 year ago

Could just have the setting in two location. But it be good if it can be change easier in the Trending tab itself.

Considering this issue is closed, I guess it be a long time before it will be revisit.