FreeTubeApp / FreeTube

An Open Source YouTube app for privacy
https://freetubeapp.io/
GNU Affero General Public License v3.0
13.37k stars 825 forks source link

[Feature Request]: Use playlist thumbnail provided by YT #3663

Open efb4f5ff-1298-471a-8973-3d47447115dc opened 1 year ago

efb4f5ff-1298-471a-8973-3d47447115dc commented 1 year ago

Guidelines

Problem Description

  1. Go to https://www.youtube.com/channel/UCXuqSBlHAE6Xw-yeJA0Tunw/playlists
  2. Compare thumbnails in FT vs YT

In FT the thumbnail of the playlist is based on the first video in that list

DefaultThumbnail1 DefaultThumbnail

Proposed Solution

If possible use the thumbnail provided by YT

Alternatives Considered

None.

Issue Labels

visual improvement

Additional Information

No response

jadenet commented 1 year ago

I've looked a bit on what could cause this and noticed that the local API gives the "correct" playlist thumbnails under thumbnail_renderer instead of thumbnails. Unfortunately though the Invidious API doesn't give the correct thumbnails, which may be a deal breaker. If it's not though, I'd be happy to make a pull request to fix only the local API.

efb4f5ff-1298-471a-8973-3d47447115dc commented 1 year ago

Hi @jadenet we're happy to accept a PR addressing only the Local API. I guess i have to create an issue over at Invidious if we want to have an fix for the Invidious API.

AtulPatidar1709 commented 1 year ago

Hello 👋 @jadenet, I want to work on this Issue, can you please assign it to me.

efb4f5ff-1298-471a-8973-3d47447115dc commented 1 year ago

Hi @AtulPatidar1709 this feature was implemented by @jadenet in https://github.com/FreeTubeApp/FreeTube/pull/3710 for the Local API.

The only thing left to do is to implement this also for the Invidious API but that needs to be done in the Invidious repo.

Here https://github.com/iv-org/invidious/issues/3939 u can find the issue that relates to the Invidious API