[Feature Request]: Catppuccin Frappe Theme

dotunwrap commented 1 year ago

Guidelines

[X] I have searched the issue tracker for open and closed issues that are similar to the feature request I want to file, without success.
[X] I have searched the documentation for information that matches the description of the feature request I want to file, without success.
[X] This issue contains only one feature request.

Problem Description

FreeTube has Catppuccin Mocha already, but I am personally a Frappe rice enjoyer. FreeTube is one of the only application on my machine that I'm rocking Mocha on. I want to add the Frappe theme to this lovely application.

Proposed Solution

Creating the theme inside of the renderer. Adding case for Frappe to the main/index.js.

Alternatives Considered

I do not believe there to be an alternative solution to adding the theme rather than on a user basis custom injecting it and building from source for personal use.

Issue Labels

new feature, visual improvement

Additional Information

There are many entries in the localizations for themes, but I will likely not be apt to add localizations for this as I only know a handful of languages.

efb4f5ff-1298-471a-8973-3d47447115dc commented 1 year ago

Only adding the strings for English US is more than enough

efb4f5ff-1298-471a-8973-3d47447115dc commented 1 year ago

U can take a look how it was done with another Catppuccin theme in https://github.com/FreeTubeApp/FreeTube/pull/2395

dotunwrap commented 1 year ago

Still working on this. Getting busy at work right now and have been working after hours on code there. Gonna get back on this weekend hopefully. Most everything is done aside from the secondary color CSS rules.

Edit: Accidentally closed. LOL

efb4f5ff-1298-471a-8973-3d47447115dc commented 12 months ago

Hi @dotunwrap could u give us an update on this? Whats the progress and do you need help with something?

dotunwrap commented 11 months ago

Hi @dotunwrap could u give us an update on this? Whats the progress and do you need help with something?

Heya @efb4f5ff-1298-471a-8973-3d47447115dc! Unfortunately, I've been stuck working 16 hours over the weekend for the past few weeks on top of my normal 40hr week. I work on an e-commerce platform, so things are ramping up in anticipation for the holiday season. Between that and spending time with family (as well as working on my personal site maybe once or twice a week), I haven't had much time to look at this.

Progress thus far actually has it almost done. The styling rules have been set for almost everything outside of the values that have to be propagated with a % based +/- in color for stuff like scrollbar hover. I also have everything showing up in the dropdown on the theme settings page, but it's displaying as the Settings.Theme Settings.Base Theme.Catppuccin Frappe value rather than the display value. Haven't looked into the code enough given my lack of time to figure out how to change that, but I assume it's a locale issue?

If my lack of time causes this branch to get too out of date and you're not receiving any updates or at least not in a timely manner, feel free to close this issue and I can reopen later when I have a bit more free time. I apologize for not being able to give it the attention I planned on when first opening the issue.

If you'd like, I can push up what I did do for the time being so that it's on a branch if anyone else wants to finish it before I have the time to. Just let me know.

efb4f5ff-1298-471a-8973-3d47447115dc commented 11 months ago

I indeed think thats a locale issue. I understand take as much time as u need and i will occasionally drop by to check on the progress :)

FreeTubeApp / FreeTube