search

FreeTubeApp / FreeTube

An Open Source YouTube app for privacy
https://freetubeapp.io/
GNU Affero General Public License v3.0
13.44k stars 834 forks source link

MPRIS ID For Freetube ? #4004

Closed ghost closed 1 year ago

ghost commented 1 year ago

Guidelines

Describe the bug

First of all sorry for not following the template.

I want to seek some clarity on the mpris id used by freetube ? Does it need chromium id for mpris or it can work with freetube.

This is needed for a recent snapcraft review question on whether its appropriate for freetube to use chromium id for mpris (snap variant used chromium as mpris id for freetube till now) .

So is there any particular project specific mpris id for freetube from flatpak i can see freetube is also valid, is this correct ?

Can freetube be used as mpris id instead of chromium.

Expected Behavior

nil

Issue Labels

usability issue

FreeTube Version

Nil

Operating System Version

Nil

Installation Method

Snapcraft (Unofficial)

Primary API used

Local API

Last Known Working FreeTube Version (If Any)

Nil

Additional Information

Nil

Nightly Build

absidue commented 1 year ago

Took a while to figure out what MPRIS is, as you didn't explain it or give any hint at what it is, I finally stumbled across a page on the arch wiki: https://wiki.archlinux.org/title/MPRIS

If you install FreeTube through one of the official install methods e.g. .deb, what MPRIS ID does it list for FreeTube when you run playerctl --list-all?

If it doesn't already say FreeTube through some Electron magic, I would recommend you follow up on this thread on the snapcraft forum, to see if they ever figured out how to set the ID in an Electron app: https://forum.snapcraft.io/t/electron-apps-and-mpris-slot/21408

As far as I can tell, if Electron/Chromium isn't already magically setting it to FreeTube, the only solution we would have would be to write a completely custom MPRIS implementation, which seems to be what Cider does (would be rather undesirable, especially considering that I had no clue what MPRIS even is just 45mins ago).

ghost commented 1 year ago

Hey there, i assumed mpris is quite common among media player hence i didn't explained it. Regarding the output of playerctl .

chromium.instance9631

It mentions chromium.

Though you didn't clear one of my question on why the flatpak variant seeks freetube as MPRIS if no custom ID Exists ?

absidue commented 1 year ago

You are asking a bunch of mostly non-Linux users highly specific Linux questions. As a Linux user, you are in a much better position to figure this stuff out, all I can do is stab in the dark internet searches.

Your best bet is probably to follow up on that snap forum thread I mentioned and ask if they ever figured out how to customise the ID.

ghost commented 1 year ago

@absidue I believe than it will be better to satisfy that freetube currently works with chromium only as a mpris tag for now, i don't want the snap to be delayed more its already running late, from the playerctl its already clear that freetube insists on using chromium as mpris id itself. In the past too my attempts to use other mpris id for the app have been futile, i believe this can be sorted out later as i & we sit on the basis of sorting out this mpris stuff it will only further delay the snap package when its evident that the devs don't themself are confident/sure on having their custom id for mpris.

Thanks nevertheless, i will still keep the snap rely on chromium for now as there is clearly no custom id for mpris with the freetube team as of now.

Edit: This issue should be kept open if the upstream agrees , i will follow the forum thread mentioned and see if in future we can get some stuff from there.