FreeTubeApp / FreeTube

An Open Source YouTube app for privacy
https://freetubeapp.io/
GNU Affero General Public License v3.0
12.41k stars 757 forks source link

[Feature Request]: Sponsorblock minimum segment length #4283

Open ghost opened 8 months ago

ghost commented 8 months ago

Guidelines

Problem Description

Currently, Sponsorblock in FreeTube will block all enabled segments regardless of length, this can lead to some frustration during videos containing multiple very tiny sponsor segments such as this video for example (https://youtu.be/BWHxXFNtIU0). At 6:40 there is a two second section of sponsor that is blocked that causes missing context relevant to the video.

Proposed Solution

A minimum segment length setting, either user-specified or with presets such as 3, 5, or 10 seconds where if a segment is shorter than this length, regardless if Sponsorblock is set to skip the segment type or not, it will not be skipped.

Alternatives Considered

N/A

Issue Labels

improvement to existing feature

Additional Information

No response

stdedos commented 1 month ago

At 6:40 there is a two second section of sponsor that is blocked that causes missing context relevant to the video.

I think that this is something that should be reported to Sponsorblock, AND checked against the YouTube player.

In either case, it would go against to how Sponsorblock is defined to work. Maybe it is exactly 2.3 seconds that the creator is going "off-topic". ... Which is especially the case with Linus (https://youtu.be/BWHxXFNtIU0).

As you can further see, this is a VIP segment https://sb.ltn.fi/video/BWHxXFNtIU0/?votes_min=-1&sort=starttime&page=

image

... which are usually auto-locked (maybe this one is somehow special).

While not an author/maintainer/contributor of either project (disclaimer: I do contribute segments to Sponsorblock), I think this is not a reasonable request for "general consumption".

efb4f5ff-1298-471a-8973-3d47447115dc commented 1 month ago

SB does have a setting for it, so i think its a valid request

Capture