FreeTubeApp / FreeTube

An Open Source YouTube app for privacy
https://freetubeapp.io/
GNU Affero General Public License v3.0
13.37k stars 825 forks source link

[Feature Request]: Quick Settings Menu #4412

Open kommunarr opened 10 months ago

kommunarr commented 10 months ago

Guidelines

Problem Description

There are certain settings that are tinkered with more regularly, like the current Invidious instance, region for trending, proxy settings, and base theme. Changing routes just to change these can be quite an onerous journey, though. And even if we do ever have t*bs, that change-settings flow is still its own journey that you have to go out of your way to embark upon.

Proposed Solution

Implement a quick settings menu for changing the most used settings. What those settings should be by default will always be up for debate & will vary based on the UX of this specific implementation. In the interest of getting things out, customization of the displayed settings are out of the scope for this issue. Also, in the interest of starting the discussion, here are my opinions on what those default quick settings should include:

This does introduce a new question of whether the user should be prompted to enter their chosen password every single time that they open the quick settings. I think you can make a convincing answer for both, depending on which settings are included. Our options are:

  1. Don't put a lock on these because they're less important - no permanent data deletion or overwrite (at the cost of allowing anyone to change these)
  2. Do put a lock on these because they may be considered important (at the cost of it being more tedious to use)
  3. Put an option to put a lock on these (at the cost of growing our ever-expanding Settings)

I would personally be fine with 1 or 3 (with lock disabled by default).

As for the UX of the control itself, it would make sense for it to be a "More Options" button near the Profile Selector icon that opens either a dropdown-ish item and/or a modal dialog box ("and/or" if it becomes a modal dialog box on smaller device sizes).

Alternatives Considered

Don't implement this feature.

Issue Labels

ease of use improvement, improvement to existing feature

Additional Information

For context, here's YT's take on it: Screenshot_20231201_192448

efb4f5ff-1298-471a-8973-3d47447115dc commented 10 months ago

Should we close https://github.com/FreeTubeApp/FreeTube/issues/1077 in favor of this?

kommunarr commented 10 months ago

I think it's a sufficiently different ask (handful of quick settings v.s. making the entire settings page a dialog), but it is worth discussing what our long-term plans for settings should be. If we did have #1077 implemented, this issue would basically become "Implement a pinned settings section". While we don't have #1077 implemented and/or if decide against implementing it (e.g., in favor of a Settings tab), this story is more in line with a quick settings menu like YT.

absidue commented 10 months ago

Just leaving a note here to say that we shouldn't be comparing it to YouTube, as that menu on YouTube contains the only settings you can change without an account. So it's not really a quick settings menu for them.