FreeTubeApp / FreeTube

An Open Source YouTube app for privacy
https://freetubeapp.io/
GNU Affero General Public License v3.0
13.5k stars 838 forks source link

[Bug]: App starts in fullscreen if you used fullscreen before quitting #4534

Open mooreye opened 9 months ago

mooreye commented 9 months ago

Guidelines

Describe the bug

  1. Watch any video in fullscreen
  2. Quit the app with ctrl+Q or just closing the window but without quitting from fullscreen first.
  3. run app again
  4. it will start in fullscreen

Expected Behavior

app resets to non-fullscreen on start

Issue Labels

accessibility issue

FreeTube Version

v0.19.1 Beta

Operating System Version

fedora 39

Installation Method

Flathub

Primary API used

Local API

Last Known Working FreeTube Version (If Any)

No response

Additional Information

No response

Nightly Build

poltpolt commented 9 months ago

I confirm on steam deck and opensuse

kommunarr commented 9 months ago

This is an interesting byproduct of this feature being implemented. Don't see an easy fix on this one without altering this feature.

absidue commented 9 months ago

We would need some way of determining during shutdown, whether the user entered full screen in the player or already before that. As there are definitely valid uses cases for having the app remembering it's full screen (e.g media centre PCs, when you full screen an app on macOS it gets moved to a separate workspace, so you can still switch back to other windows), but I can completely understand you don't want FreeTube starting in full screen if you only did it to watch a video in full screen.

poltpolt commented 9 months ago

on steam deck with no physical keyboard/mouse the only dirty tricky to switch to other windows or even exit is clicking the links in "About" to get firefox open. Otherwise you are stuck with touchscreen, unable to minimise or close. ~2Million steam decks running worldwide

maybe a button for both close and minimise somewhere?

xypage commented 9 months ago

This is an interesting byproduct of this feature being implemented. Don't see an easy fix on this one without altering this feature.

Could we just add an option to disable that entirely then? I imagine most people (me included) don't use full screen while navigating, so there would be no need to remember state since it's something for videos and not the surrounding UI. Maybe an option to default to windowed, full screen, or last used?

lothar-cell commented 8 months ago

I actually asked for this feature specifically:D https://github.com/FreeTubeApp/FreeTube/issues/1535 I always use the app in fullscreed and navigate between spaces with gestures. For example Apple Mail and Spotify have this feature built-in, because it is really annoying to press the fullscreen button every time when starting up the app.

poltpolt commented 8 months ago

I actually asked for this feature specifically:D #1535 I always use the app in fullscreed and navigate between spaces with gestures. For example Apple Mail and Spotify have this feature built-in, because it is really annoying to press the fullscreen button every time when starting up the app.

valid point but you have to have an option to quit or minimise the app to regular size - with touchscreen only , there is no way to do it.

github-actions[bot] commented 7 months ago

This issue is stale because it has been open 28 days with no activity. Remove stale label or comment or this will be closed in 7 days.

2Shot0ccurence commented 7 months ago

For me this problem is actually persistent after a full reinstall.

Victor239 commented 7 months ago

Is this an irreversible change? I accidentally closed once whilst fullscreen and now it's forever opening in fullscreen.

absidue commented 7 months ago

@Victor239 Press F11 to exit full screen, close FreeTube and when you reopen it, it should open normally again.

Victor239 commented 7 months ago

Thanks! I was disabling fullscreen by through right-clicking the app in my Task Manager (KDE) and unchecking the fullscreen box which didn't change things for next launch, pressing F11 instead worked.

github-actions[bot] commented 6 months ago

This issue is stale because it has been open 28 days with no activity. Remove stale label or comment or this will be closed in 7 days.

poltpolt commented 6 months ago

pressing F11 is not really a solution on keyboardless setups like steamdeck, that is why a button in gui would be appreciated.

absidue commented 6 months ago

@poltpolt Pressing F11 was never meant to be a solution, it's a workaround, adding extra buttons that are pointless for most of FreeTube's users, is just another workaround.

If you have a suggestion for an actual solution, please mention it, but repeating the same thing again and again, that isn't a solution, helps nobody.

poltpolt commented 6 months ago

@absidue I think you underestimate the number of Steamdeck+FreeTube users

github-actions[bot] commented 5 months ago

This issue is stale because it has been open 28 days with no activity. Remove stale label or comment or this will be closed in 7 days.

github-actions[bot] commented 4 months ago

This issue is stale because it has been open 28 days with no activity. Remove stale label or comment or this will be closed in 7 days.

github-actions[bot] commented 3 months ago

This issue is stale because it has been open 28 days with no activity. Remove stale label or comment or this will be closed in 7 days.

github-actions[bot] commented 2 months ago

This issue is stale because it has been open 28 days with no activity. Remove stale label or comment or this will be closed in 7 days.

github-actions[bot] commented 1 month ago

This issue is stale because it has been open 28 days with no activity. Remove stale label or comment or this will be closed in 7 days.

4-FLOSS-Free-Libre-Open-Source-Software commented 1 month ago

I do like to start the app in fullscreen always. How to make sure?

github-actions[bot] commented 2 weeks ago

This issue is stale because it has been open 28 days with no activity. Remove stale label or comment or this will be closed in 7 days.