[Feature Request]: Scroll Volume Over Video Player show temporary HUD reflecting change

Alice-Cheshire commented 8 months ago

Guidelines

[X] I have searched the issue tracker for open and closed issues that are similar to the feature request I want to file, without success.
[X] I have searched the documentation for information that matches the description of the feature request I want to file, without success.
[X] This issue contains only one feature request.

Problem Description

The Scroll Volume Over Video Player setting is good but there is one rather annoying issue with it: There's no real feedback on it.

Proposed Solution

From my searches in the issues, it seems like the basic concept was based on the one from Youtube Enhancer. It'd be rather convenient if it also included the on-screen volume display like Youtube Enhancer does as well.

Alternatives Considered

Not really sure what alternatives there would even be.

Issue Labels

display more information to user, ease of use improvement, improvement to existing feature, visual improvement

Additional Information

No response

efb4f5ff-1298-471a-8973-3d47447115dc commented 8 months ago

Volume percentage was present in a stable release at some point but was removed because it had some issues that couldnt be solved.

@absidue could the player migration ve of any use here? If not ill close this.

Alice-Cheshire commented 8 months ago

Volume percentage was present in a stable release at some point but was removed because it had some issues that couldnt be solved.

Related issue: #1285

@absidue could the player migration ve of any use here? If not ill close this.

I'm referring to a feature that's in the latest release from the releases page (v0.19.1 Beta), so I'm not sure you're talking about the same thing I am.

absidue commented 8 months ago

Is referring to the disabled by default setting that allows you to adjust the volume by scrolling over the entire player? As you definitely get feedback if you scroll over the volume slider (you see the slider move).

Alice-Cheshire commented 8 months ago

Is referring to the disabled by default setting that allows you to adjust the volume by scrolling over the entire player? As you definitely get feedback if you scroll over the volume slider (you see the slider move).

I'm referring to Settings -> Player Settings -> Scroll Volume Over Video Player

As for the feedback part, that only happens if you mouse over the volume icon so the bar is even visible but it's also not nearly as accurate as a proper number. (As a side note, I also realized there's no control over the increment of how much scrolling changes the volume so I can't reproduce what I'd have on Youtube since FreeTube goes for 5% with no options I have it set to 1% in my browser since videos by some uploaders I subscribe to are way louder than others and 5% for them is an enormous difference while for others it's basically nothing.)

Also what happened to the issue's title? I'm not seeing anything about anyone changing the title but I definitely filled out the title field when I opened the issue.

absidue commented 8 months ago

Also what happened to the issue's title? I'm not seeing anything about anyone changing the title but I definitely filled out the title field when I opened the issue.

I've added a title for you now. I've also updated the issue body so that it specifically mentions the setting that you are talking about.

I'm referring to Settings -> Player Settings -> Scroll Volume Over Video Player

Okay glad to know that we are talking about the same thing (this is what I meant by the disabled by default setting that lets you change the volume when scrolling over the entire player).

As for the feedback part, that only happens if you mouse over the volume icon so the bar is even visible but it's also not nearly as accurate as a proper number.

Scrolling over that is available without the other setting enabled and realistically we don't need anymore feedback for that than there already is, as you can hear the change and the already have the visual indication of the slider moving.

Alice-Cheshire commented 8 months ago

As for the feedback part, that only happens if you mouse over the volume icon so the bar is even visible but it's also not nearly as accurate as a proper number.

Scrolling over that is available without the other setting enabled and realistically we don't need anymore feedback for that than there already is, as you can hear the change and the already have the visual indication of the slider moving.

I would strongly disagree with that but it seems like you've made up your mind so alright then. I guess I'll just stick to FreeTube until Youtube's current war against adblockers dies down then just switch back to using my browser.

absidue commented 8 months ago

Reopening, as you seem to have misunderstood that I am talking about two separate things.

Scrolling over the volume slider is always enabled and is something different than the disabled by default Scroll Volume Over Video Player setting. The first one just intercepts scrolling on the volume slider, the second one intercepts scrolling anywhere on the player.

The former has enough feedback already (the slider moves when you scroll), the latter doesn't have any visual indication that anything is happening, which is what you opened this issue for in the first place.

Alice-Cheshire commented 8 months ago

Reopening, as you seem to have misunderstood that I am talking about two separate things.

Scrolling over the volume slider is always enabled and is something different than the disabled by default Scroll Volume Over Video Player setting. The first one just intercepts scrolling on the volume slider, the second one intercepts scrolling anywhere on the player.

The former has enough feedback already (the slider moves when you scroll), the latter doesn't have any visual indication that anything is happening, which is what you opened this issue for in the first place.

That definitely wasn't clear to me. I would agree that extra feedback isn't really necessary for that case since you would always be able to see the volume bar while doing it in that context.

FreeTubeApp / FreeTube