FreeTubeApp / FreeTube

An Open Source YouTube app for privacy
https://freetubeapp.io/
GNU Affero General Public License v3.0
13.37k stars 825 forks source link

[Feature Request]: Settings search #4726

Open codenyte opened 7 months ago

codenyte commented 7 months ago

Guidelines

Problem Description

It can sometimes be hard to find something on the settings page

Proposed Solution

(Fuzzy) search feature for the settings page

Alternatives Considered

I think the individual sections of the settings page, that are hidden by default are what make the settings so confusing. An alternative would be to show all options by default, and have something like a table of content on the side, which allows the user to jump to a specific section.

Issue Labels

ease of use improvement, new feature

Additional Information

This is probably a duplicate, but FreeTube has over 2500 issues and GitHub's search is really bad.

kommunarr commented 5 months ago

Trying to imagine the UX for this. The matching settings section(s) appear with only the matching setting(s) in them, I guess? Either that or one "unified" results grouping, but then you're not helping people know which section has it for next time.

efb4f5ff-1298-471a-8973-3d47447115dc commented 5 months ago

Query returns list with the settings that matches that query and also shows the route to that setting

https://github.com/FreeTubeApp/FreeTube/assets/73130443/d5cd428c-c518-4054-9793-a295f5b8c00a

stdedos commented 5 months ago

It's up-to-par with how e.g. NewPipeX is working

image

My personal preference would be a sticky section header (that works well with the single-level grouping that settings have)

pkrasicki commented 2 days ago

Is this still needed after the recent redesign implemented in PR #5029? The settings page should be much easier to navigate now. Another thing that might make things easier could be switching to single column layout:

settings-restyled2

efb4f5ff-1298-471a-8973-3d47447115dc commented 2 days ago

Another thing that might make things easier could be switching to single column layout:

While i really like this idea i dont think this would be feasible as some of our settings would become really long.

efb4f5ff-1298-471a-8973-3d47447115dc commented 2 days ago

Is this still needed after the recent redesign implemented in PR #5029? The settings page should be much easier to navigate now

In theory we can close this as the alternative has been implemented.

An alternative would be to show all options by default, and have something like a table of content on the side, which allows the user to jump to a specific section.

@codenyte would it be possible for you to try out the RC

stdedos commented 2 days ago

My 2c:

Finding the exact specific setting one is looking for is orthogonal to any visual layout :pray:

efb4f5ff-1298-471a-8973-3d47447115dc commented 2 days ago

If we implement #5872 then this would definitely still be useful

If we dont than i think we can close this in favor of #1401

pkrasicki commented 2 days ago

Another thing that might make things easier could be switching to single column layout:

While i really like this idea i dont think this would be feasible as some of our settings would become really long.

@efb4f5ff-1298-471a-8973-3d47447115dc I've been testing this in 0.23 (so without the new menu), the longest section is SponsorBlock and it doesn't seem so bad to me. It takes some getting used to, but it should be pretty convenient with the new tabs.

https://github.com/user-attachments/assets/c8d92383-a80e-47d8-906f-304bc6eb91e3

codenyte commented 2 days ago

Is this still needed after the recent redesign implemented in PR #5029? The settings page should be much easier to navigate now

In theory we can close this as the alternative has been implemented.

An alternative would be to show all options by default, and have something like a table of content on the side, which allows the user to jump to a specific section.

@codenyte would it be possible for you to try out the RC

The new settings page is definitely much nicer, but one of my biggest issues with the settings was that it's not always clear in which category to look for a specific setting. For example, the Proxy category refers to network proxies, but it could also just as well be referring to the Invidious proxy used for video playback. I don't think a search feature is strictly necessary, but I believe it would make the experience nicer and easier for new users. I'm not gonna close the issue, but it someone feels like closing it, because implementing a search feature is not worth the effort, go ahead.

Btw why is there no ARM64 build for macOS? Even Linux appears to have one, even though ARM Macs are much more common than Linux machines?