FreeTubeApp / FreeTube

An Open Source YouTube app for privacy
https://freetubeapp.io/
GNU Affero General Public License v3.0
13.29k stars 826 forks source link

[Bug]: Images strechted on Community page #4852

Open efb4f5ff-1298-471a-8973-3d47447115dc opened 6 months ago

efb4f5ff-1298-471a-8973-3d47447115dc commented 6 months ago

Guidelines

Describe the bug

  1. Go to https://www.youtube.com/@ludwig/community
  2. See that some posts are stretched

https://github.com/FreeTubeApp/FreeTube/assets/73130443/469f3dd5-38c5-41fa-836e-352694b41c5d

Expected Behavior

Community posts shouldn't be stretched.

Issue Labels

visual bug

FreeTube Version

v0.20.0-nightly-4137 Beta

Operating System Version

Win10 22H2

Installation Method

.exe

Primary API used

Local API

Last Known Working FreeTube Version (If Any)

No response

Additional Information

No response

Nightly Build

github-actions[bot] commented 5 months ago

This issue is stale because it has been open 28 days with no activity. Remove stale label or comment or this will be closed in 7 days.

github-actions[bot] commented 4 months ago

This issue is stale because it has been open 28 days with no activity. Remove stale label or comment or this will be closed in 7 days.

github-actions[bot] commented 3 months ago

This issue is stale because it has been open 28 days with no activity. Remove stale label or comment or this will be closed in 7 days.

tzwel commented 2 months ago

Hey, I'd like to take this one. As far as I see, just adding object-fit: cover; to the images fixes the problem, but the aspect ratio differs from Youtube is using (1:1) and this makes the images cropped unnecessarily. Is it ok if I make the columns and images wider also? This fixes the issue image

efb4f5ff-1298-471a-8973-3d47447115dc commented 2 months ago

Sure create a PR for it and if we feel like there are changes needed we will let you know :)

github-actions[bot] commented 1 month ago

This issue is stale because it has been open 28 days with no activity. Remove stale label or comment or this will be closed in 7 days.

github-actions[bot] commented 4 weeks ago

This issue is stale because it has been open 28 days with no activity. Remove stale label or comment or this will be closed in 7 days.