FreeTubeApp / FreeTube

An Open Source YouTube app for privacy
https://freetubeapp.io/
GNU Affero General Public License v3.0
12.94k stars 798 forks source link

[Bug]: Video is shifted and cropped when pausing in full screen after controls disappear #4983

Open Damus765 opened 4 months ago

Damus765 commented 4 months ago

Guidelines

Describe the bug

  1. Play any video in FreeTube.
  2. Click on the "Fullscreen" button or double-click on the player to go full screen.
  3. Don't move the pointer and wait for the controls and overlay to disappear.
  4. Click on the player (without moving the pointer) or press the space bar on your keyboard to pause the video.
  5. The video is shifted down by 60px, and the bottom 60px are cropped.
  6. When playback resumes, the video returns to its original position

I don't know if this is related, but my screen resolution is 1920*1200, with a scaling factor of 125%. I tried to take a screen capture, to have a video of the issue. But interestingly, while the capture is running I am unable to reproduce the issue. So I just took a screenshot, which is attached below. This may be a video.js bug, but I never experienced this behavior anywhere else.

Expected Behavior

The video should remain at the same position and dimension during playback and pause.

Issue Labels

visual bug

FreeTube Version

v0.20.0

Operating System Version

Windows 11 version 23H2

Installation Method

.exe

Primary API used

Local API

Last Known Working FreeTube Version (If Any)

v0.19.2

Additional Information

Video playing: Video_playing

Video paused: Video_paused

Nightly Build

efb4f5ff-1298-471a-8973-3d47447115dc commented 4 months ago

Im unable to reproduce this on Win10

Damus765 commented 3 months ago

I tried to find a solution for this issue, but to no avail so far. The only thing I can tell is that it seems to be related to my screen resolution of 1920x1200. If I switch to 1920x1080, I can't reproduce it anymore.

But anyway, this is most likely a video.js bug. If I try with the Shaka Player, the issue is not there anymore. So we may close this when #4978 is merged.

github-actions[bot] commented 2 months ago

This issue is stale because it has been open 28 days with no activity. Remove stale label or comment or this will be closed in 7 days.

github-actions[bot] commented 1 month ago

This issue is stale because it has been open 28 days with no activity. Remove stale label or comment or this will be closed in 7 days.

github-actions[bot] commented 1 week ago

This issue is stale because it has been open 28 days with no activity. Remove stale label or comment or this will be closed in 7 days.