FreeTubeApp / FreeTube

An Open Source YouTube app for privacy
https://freetubeapp.io/
GNU Affero General Public License v3.0
13.08k stars 810 forks source link

[Feature Request]: Transient "hide watched" toggle #4999

Open kommunarr opened 4 months ago

kommunarr commented 4 months ago

Guidelines

Problem Description

As a user, I sometimes want to hide watched videos in my subscriptions only sometimes. Rather than have to enable and disable a permanent setting, I would like to be able to do it on a whim and have it revert when it's no longer desired.

Proposed Solution

Implement transient toggle switch somewhere on the Subscriptions page (like the ft-refresh-widget or the top of the page) that overrides the "Hide Videos on Watch" preference until the route is changed.

Alternatives Considered

Have the toggle override the default setting for the session instead of just until route change.

Issue Labels

ease of use improvement, improvement to existing feature

Additional Information

No response

ankitchauhan-aka commented 4 months ago

Can I work on this!

kommunarr commented 4 months ago

Thanks for your enthusiasm @ankitchauhan-aka! Let me first invite the other contributors to provide their feedback on if and how we want this feature look. CC: @efb4f5ff-1298-471a-8973-3d47447115dc @absidue @ChunkyProgrammer @PikachuEXE @MarmadileManteater

MarmadileManteater commented 4 months ago

My opinion is that we should try to limit the number of floating transient things on the page, but I understand the desire for this feature because the current Hide Watched setting is not reactive as-is.

kommunarr commented 4 months ago

I agree with both of those sentiments. Part of my mindset is that I would never really want to have "Hide Videos on Watch" enabled permanently, but I would like to be able to toggle it on/off at will when looking at my open subscription videos. I sometimes will open a video and want to go back to it when I see it on my feed, so I wouldn't want it always be on. You could also make a similar but less salient case for "Only Show Latest Video for Each Channel". I wonder if something like an icon checkbox dropdown from #4231 would work for this.

ChunkyProgrammer commented 4 months ago

Maybe we could have a "Show Hidden results" link/button that appears if there's anything that's hidden (this can apply to subscriptions and searching if you have blocked any channels/tags). There should also probably be a parental control to prevent that link/button from showing though (on the search page at least)

kommunarr commented 4 months ago

That's an interesting idea, I like that. Maybe that setting is a dropdown if we want to distinguish among "Hide 'Show hidden' button", "Always hide blocked words and channels", and "Default"? Or maybe just a toggle for MVP.

efb4f5ff-1298-471a-8973-3d47447115dc commented 4 months ago

Just to be clear this issue isnt part of these issues: https://github.com/FreeTubeApp/FreeTube/issues/4412 and #1077 ?

kommunarr commented 4 months ago

Removing "good first issue" for now as the exact design is still somewhat in the air.