FreeTubeApp / FreeTube

An Open Source YouTube app for privacy
https://freetubeapp.io/
GNU Affero General Public License v3.0
13.37k stars 825 forks source link

[Feature Request]: Update label casing to sentence case #5000

Open kommunarr opened 6 months ago

kommunarr commented 6 months ago

Guidelines

Problem Description

Our labels throughout FreeTube vary between sentence case and title case. There is no consistency, and this can at times be mildly jarring visually.

Proposed Solution

Standardize all labels in FreeTube under sentence case, the one preferred by many style guides (see discussion here as well). We can do this either programmatically or manually (which sounds terrible). If programmatically, apply to all elements descending from the root of the document - this should take one rule, and maybe getting rid of any text-transforms elsewhere if they clash with this vision. Any exceptions to this rule should be exceptionally rare. I don't think we can write exceptions for labels starting with a word that should be lowercase given our large amount of supported languages, but that's fine. Of course, this does not apply to modifying user-generated content, unless we're talking about Display Titles Without Excessive Capitalisation And Punctuation, which @efb4f5ff-1298-471a-8973-3d47447115dc has rightly called out needs to be retested with the implementation of this feature.

Test modals and sections throughout the app to confirm that there are no issues with visually portraying the hierarchy with this change. If there are any, use additional styling like bolding and minor size differentials to resolve them.

Alternatives Considered

None

Issue Labels

visual improvement

Additional Information

No response

efb4f5ff-1298-471a-8973-3d47447115dc commented 6 months ago

I think Distraction free setting: Display Titles Without Excessive Capitalisation And Punctuation should be retested in PR

kommunarr commented 5 months ago

Removing "good first issue" as I feel like it might take some thought on how to actually do this. If we do it programmatically, for example, how would that affect languages like German, where capitalization is often necessary? We could probably have a set of languages not included, but then that's going beyond new contributor territory.

kommunarr commented 5 months ago

To do it programmatically, we'd also need a set of proper nouns saved to know not to make lowercase. It seems almost like a manual solution for EN-US would be better, then just hope that translations in other languages where sentence casing is preferred follow suit. I don't know of any better options at the moment.