[Feature Request]: Remember the Playlists "Sort By" selection between sessions

profucius commented 2 months ago

Guidelines

[X] I have searched the issue tracker for open and closed issues that are similar to the feature request I want to file, without success.
[X] I have searched the documentation for information that matches the description of the feature request I want to file, without success.
[X] This issue contains only one feature request.

Problem Description

Currently, the Sort By dropdown selection box forgets the chosen selection between sessions (close Freetube and then launch again). It always defaults to "Recently Played". I want it to remember which choice was last selected between sessions.

Proposed Solution

Make it remember the last chosen selection.

You can implement this similarly to this: In the beta build 4242 (at least), within a playlist there is another "Sort By" dropdown selection box. This selection does remember the last chosen selection between sessions.

Alternatives Considered

No alternatives.

Issue Labels

improvement to existing feature

Additional Information

kommunarr commented 2 months ago

Inviting discussion from other contributors, but I think this is a reasonable change. If someone changed that sort, they probably would want to keep it. This is especially relevant for #4594, where we wouldn't want the sort order of the inline playlists reverting if it was changed in a given session.

efb4f5ff-1298-471a-8973-3d47447115dc commented 2 months ago

The add to playlist window also has a sort by that works in the same way as the OP described. Should we also change that? Im not sure

Edit: im fine with the change for this page

kommunarr commented 2 months ago

The add to playlist window also has a sort by that works in the same way as the OP described. Should we also change that?

I honestly think if we make the Playlist search UX more compact, we do not need either the Add Video to Playlist search bar or sort dropdown. So I think it's fine that we keep it the same for now. That, and that mode is far more transient than this, I would say.

ArthurKun21 commented 2 months ago

Would it also be possible to also remember the sorting of it when you played a playlist. Like when you sort latest added first when you play the playlist it would also be the same

kommunarr commented 2 months ago

Would it also be possible to also remember the sorting of it when you played a playlist. Like when you sort latest added first when you play the playlist it would also be the same

If you're talking about having the user playlist sort order being reflected in the box on the /Watch route, this is a separate issue that I have a soon-to-be-released PR for.

susansli commented 1 month ago

Hi! I would like to do this issue.

keerthana054 commented 1 month ago

Hi! Can I work on this issue.

susansli commented 1 month ago

@keerthana054 I was planning to do it soon now that I have some downtime.

keerthana054 commented 1 month ago

@keerthana054 I was planning to do it soon now that I have some downtime.

ok. kindly let me know, if I can contribute to this work in any way. Thank you

efb4f5ff-1298-471a-8973-3d47447115dc commented 1 month ago

@keerthana054 I was planning to do it soon now that I have some downtime.

@susansli could you be more specific on what you mean with soon? It would be nice to include this into the upcoming release :)

susansli commented 1 month ago

Hi, someone can take over for me. I had something come up - appreciate the opportunity though!

efb4f5ff-1298-471a-8973-3d47447115dc commented 1 month ago

@keerthana054 would you like to take this?

FreeTubeApp / FreeTube