FreeTubeApp / FreeTube

An Open Source YouTube app for privacy
https://freetubeapp.io/
GNU Affero General Public License v3.0
13.39k stars 828 forks source link

[Feature Request]: Show unified view when viewport width can only fit one row of content #5012

Open kommunarr opened 6 months ago

kommunarr commented 6 months ago

Guidelines

Problem Description

Mobile devices, below a certain width threshold, aren't actually ever getting a Video View Type of grid. Rather, we have styling rules that make the grid display attempt to emulate the list view. This is more code to maintain, and an additional scenario to test for each new feature.

Proposed Solution

Force the list view for mobile devices on all routes. This allows us to reduce the amount of code we have to maintain and test. See the resize event listener in ft-list-video.js to see how we check for this condition. If we have any unrelated grievances with the mobile List view that we have been putting off because not enough of us actually use the list view, we should also fit in some changes there as well if possible (most expediently by stealing certain rules from the grid mobile view, or more ambitiously by pursuing a broader rework of the ft-list-video mobile appearance).

This may be partly dependent on #5007 if we think that the visual real estate afforded by that change for mobile users will allow us to have more flexibility.

Alternatives Considered

None come to mind. Maybe switching to grid as the mobile default on specific views where it looks better, but that seems insufficient & somewhat complicated to keep track of.

Issue Labels

improvement to existing feature, visual improvement

Additional Information

No response

absidue commented 6 months ago

Currently the single column gird view is the best experience on mobile, as the list view is designed for wide screens and displays things horizontally next to each other, but the grid view displays things vertically, so it works a lot better.

kommunarr commented 6 months ago

Thanks for that clarification @absidue. We can probably just get rid of the list mobile styling and supplant it with the grid's as the starting point (probably making it sound easier than it is with all the inherited styles and minor structural differences, but ya know).

Eiion commented 3 months ago

I'm very much against the forcing of a default list view on mobile devices. Using the app on a 10.1" tablet (which is considered a mobile device) there's a lot of screenspace for grid view. List view is actually extremely wasteful of the latter and also very user unfriendly considering all the scrolling required.

If anything, when installing the app there should be a setup wizard asking you if you want grid or list view.

kommunarr commented 3 months ago

To clarify, the original issue is pertaining to when the viewport width can only contain one item max in grid view. I'll update the title to reflect that we want it to be grid view as the default, because mobile list view is actually not very good looking for that case. That recommendation you're suggesting is represented by #4332, and I do think it's a good idea.