FreeTubeApp / FreeTube

An Open Source YouTube app for privacy
https://freetubeapp.io/
GNU Affero General Public License v3.0
13.12k stars 812 forks source link

[Bug]: Reloading video (crtl-r) reloads a window other than the focused one. #5039

Open Lee-Adamson opened 4 months ago

Lee-Adamson commented 4 months ago

Guidelines

Describe the bug

FreeTube 0.20.0 running on x64 Linux. Notion window manager (though I doubt that has anything to do with it). Opening several videos in new windows from the subscriptions list, so as to watch later. After leaving the machine some for some hours and coming back to watch videos, they've lost connection and have to be reloaded (crtl-r). However, pressing ctrl-r always refreshes the first window that was opened in the stack, not the one that is currently focused.

Expected Behavior

Reloading the video (ctrl-r) should reload the currently focused window, not a backgrounded unfocused one.

Issue Labels

content not loading, keyboard control not working, usability issue

FreeTube Version

0.20.0 Beta

Operating System Version

Linux X64 (Devuan stable)

Installation Method

.deb

Primary API used

Local API

Last Known Working FreeTube Version (If Any)

Unknown

Additional Information

No response

Nightly Build

kommunarr commented 4 months ago

Cannot replicate (Linux x64, portable). If you were to open up two windows from a fresh session and hit Ctrl+R, does it work correctly, or does it only happen after all windows are open for a while?

Lee-Adamson commented 4 months ago

Fresh session in Notion still behaves as described above. But then I fired it up in Xephyr with a non-tiling/tabbed window manager (Openbox) and it behaves as expected. I still believe that there is some manner of funny business going on with Freetube though, as this sort of thing only happens with Freetube, not with any other applications.

efb4f5ff-1298-471a-8973-3d47447115dc commented 4 months ago

@Lee-Adamson Does the same issue happen for other Electron apps such as Visual Studio Code or Discord to mention some well-known ones?

Lee-Adamson commented 4 months ago

I have been unable to suss out how to open multiple windows in Discord or Element. They both seem to use modal dialogs for everything.

So I installed VS Code for testing purpose. I opened 3 different windows and moved them to different tab groups within Notion window manager. In any of these three windows, I can press control-shift-P and type "reload window". Doing so causes all three of the windows to close and then all three quickly reopen in the currently focused WM tab.

So the way Freetube and VSCode are handling reloading seems different. If there are any further tests I can do or other Electron applications you can recommend I try, please let me know.

github-actions[bot] commented 3 months ago

This issue is stale because it has been open 28 days with no activity. Remove stale label or comment or this will be closed in 7 days.

efb4f5ff-1298-471a-8973-3d47447115dc commented 2 months ago

Does this issue still persist for you on v0.21.0?

Lee-Adamson commented 2 months ago

Does this issue still persist for you on v0.21.0?

Yes. Thanks.

github-actions[bot] commented 1 month ago

This issue is stale because it has been open 28 days with no activity. Remove stale label or comment or this will be closed in 7 days.

Lee-Adamson commented 1 month ago

Bug still present in 0.21.1.

github-actions[bot] commented 2 weeks ago

This issue is stale because it has been open 28 days with no activity. Remove stale label or comment or this will be closed in 7 days.

Lee-Adamson commented 2 weeks ago

Bug still present in 0.21.3 Beta.