FreeTubeApp / FreeTube

An Open Source YouTube app for privacy
https://freetubeapp.io/
GNU Affero General Public License v3.0
12.36k stars 754 forks source link

[Bug]: Videos don't open in Theatre Mode even if "Enable Theatre Mode by Default" is checked #5252

Open PrivacyFriendlyMuffins opened 3 weeks ago

PrivacyFriendlyMuffins commented 3 weeks ago

Guidelines

Describe the bug

Even if Settings > Player Settings > Enable Theatre Mode by Default is enabled ...

Freetube Settings

... videos will still open in regular view mode.

Freetube Regular Mode

(Clicking the Theatre Mode icon in the video toolbar will still successfully toggle between the two states, though.)

Expected Behavior

When "Enable Theatre Mode by Default" under Settings > Player Settings is set to On, videos should open in Theatre Mode.

Freetube Theatre Mode

Issue Labels

feature stopped working

FreeTube Version

v0.20.0 Beta

Operating System Version

Windows 10 Home version 22H2

Installation Method

.exe

Primary API used

Local API

Last Known Working FreeTube Version (If Any)

v0.19.2 Beta

Additional Information

No response

Nightly Build

efb4f5ff-1298-471a-8973-3d47447115dc commented 3 weeks ago

Unable to replicate this on the master branch and on my locally installed nightly build

efb4f5ff-1298-471a-8973-3d47447115dc commented 3 weeks ago

Could you do the following:

  1. Open up the dev tools: ctrl+shift+i
  2. Show that the setting is enabled
  3. Go to a video
PrivacyFriendlyMuffins commented 3 weeks ago
1. Open up the dev tools: `ctrl+shift+i`

Done.

2. Show that the setting is enabled

Okay, how do I do that?

efb4f5ff-1298-471a-8973-3d47447115dc commented 3 weeks ago

Apologies forgot to mention that you need to provide a screen recording of those steps

PrivacyFriendlyMuffins commented 3 weeks ago

Sorry for the late reply. Work and weird hours, you know how it goes. Lol.

Just so I understand you correctly, do you want a screen recording or a screen shot? If a screen recording, I don't know of any software that can do that. Sorry. :( If a screenshot, then no problem; it's above in my original post.

Apologies if I'm misunderstanding...

kommunarr commented 3 weeks ago

@PrivacyFriendlyMuffins Here's an article I found on how to do that in Windows 10, if it helps!

PrivacyFriendlyMuffins commented 3 weeks ago

Thank you!

That being said, did you want a screen recording of the setting being turned on or "something something something dev tools"? Because once I pressed shift+ctrl+I, I didn't know what to do to make sure the setting was on. Lol.

PhilJbt commented 2 weeks ago

@PrivacyFriendlyMuffins does this occur only on playlists, like me? I noticed this for a while now, I thought it was just not implemented for playlist, but only for regular watched videos.

Actually on v0.21.0 Beta: bundle-1718953864154.log

2024-06-21 09-10-31.webm

kelvin-wong commented 2 weeks ago

I have the same issue. It could be reproducible by enabling Hide Recommended Videos in Distraction Free Settings.

PhilJbt commented 2 weeks ago

I have the same issue. It could be reproducible by enabling Hide Recommended Videos in Distraction Free Settings.

I can confirm, it was enabled from my side. Disable it fixes the bug.

PrivacyFriendlyMuffins commented 2 weeks ago

@PrivacyFriendlyMuffins does this occur only on playlists, like me? I noticed this for a while now, I thought it was just not implemented for playlist, but only for regular watched videos.

Yes, I hadn't noticed at the time, but checking that, it does seem to only happen on Playlists. If I watch a video from my Subscriptions section, it works just fine.

I have the same issue. It could be reproducible by enabling Hide Recommended Videos in Distraction Free Settings.

I can confirm, it was enabled from my side. Disable it fixes the bug.

Can confirm this fixes the bug. Unfortunately, that means seeing recommended videos. Lol. But for a short-term solution, it does the trick. thumbs-up (Side note & totally unrelated: I really wish there was an emoticon for thumbs-up. Haha.)