FreeTubeApp / FreeTube

An Open Source YouTube app for privacy
https://freetubeapp.io/
GNU Affero General Public License v3.0
13.37k stars 825 forks source link

[Bug]: Comment reply count is possibly outdated, even after fetching replies #5532

Closed TheodorSmall closed 1 month ago

TheodorSmall commented 2 months ago

Guidelines

Describe the bug

When loading comments, their respective number of replies is fetched. However, if new replies are submitted in the meantime, just before the user clicks "view n replies", this count may be outdated, and there may be more (in theory, I suppose also less) replies than earlier, when the main comment was fetched.

The suggested fix is to update the reply count after fetching comment replies.

Expected Behavior

The correct reply count should be updated after fetching the replies.

Issue Labels

text/string issue, visual bug

FreeTube Version

v0.21.3 Beta (built from source at development/79ca2a)

Operating System Version

Linux 6.6.36-1-lts #1 SMP PREEMPT_DYNAMIC x86_64 GNU/Linux

Installation Method

.pacman

Primary API used

Invidious API

Last Known Working FreeTube Version (If Any)

not known, probably none

Additional Information

No response

Nightly Build

github-actions[bot] commented 1 month ago

This issue is stale because it has been open 28 days with no activity. Remove stale label or comment or this will be closed in 7 days.

absidue commented 1 month ago

FreeTube's behaviour matches YouTube's in this regard, it shows the count at the time that the comment was fetched, which yes can also be higher than the amount of replies that are actually shown, as YouTube' servers also count comments that are being held for review, so not returned in the response, in their replies count. So if anything this is a feature request, additionally if there is more than one page (each page contains 10 replies) of replies for a given comment you would have to click show more replies until you have fetched every available reply for that comment before we could update the count.

efb4f5ff-1298-471a-8973-3d47447115dc commented 1 month ago

Closing as this isnt a bug. I don't think that its worth filing a bug report because counting all the replies to see if they match the number when there are a large number of replies seems very unreasonable.

Also YT sometimes also shows that there are for example 11 replies but only shows 9 because the others are deleted and they themselves didn't update the number