FreeTubeApp / FreeTube

An Open Source YouTube app for privacy
https://freetubeapp.io/
GNU Affero General Public License v3.0
13.47k stars 836 forks source link

[Feature Request]: Configurable Default Subtitle Language setting #5867

Open AmyMagdalena opened 2 weeks ago

AmyMagdalena commented 2 weeks ago

Guidelines

Problem Description

Hi, I have FreeTube's UI set to Catalan and subtitles defaulting to on, and this is great, however I watch a lot of English language content and as a native speaker of English, google translated Catalan being the default isn't very desirable. However I also have audio processing disorder as a symptom of my ADHD and so I like having English subtitles.

Proposed Solution

Allow subtitle language to be set to Original Language

Alternatives Considered

Allow a default language or priority list for languages to be set

Issue Labels

new feature, new optional setting

Additional Information

imatge imatge

efb4f5ff-1298-471a-8973-3d47447115dc commented 2 weeks ago

Maybe we need configurable subtitle settings instead.

Lets say user UI is in Hindi but configures subtitle to be set to English by default.

We could configure the fallback in this order.

English provided by the creator of the video -> Auto generated English -> UI language translated from English.

AmyMagdalena commented 2 weeks ago

English provided by the creator of the video -> Auto generated English -> UI language translated from English.

the last one in this list would never get used

efb4f5ff-1298-471a-8973-3d47447115dc commented 2 weeks ago

Im sorry im not sure i understand you correctly. Could you elaborate some more on this?

AmyMagdalena commented 2 weeks ago

In a situation where the 3rd entry "UI language translated from English" occurs, one of the first 2 entries have already occured and thus it would not occur. I think perhaps you meant to say "UI language translated from non-english" where it could then occur.

efb4f5ff-1298-471a-8973-3d47447115dc commented 2 weeks ago

Lets take the following example. This would be the fallback strategy when my UI is set to Dansk/Danish and i configured subtitle to be set to English by default.

Screenshot (346)

If English is not provided by creator of video then fallback to English Auto generated. If English Auto generated is not available fallback to Danish (Translated from "English")

AmyMagdalena commented 2 weeks ago

3 could fire if it was Danish (translated from "German"), it couldn't fire if it was Danish (translated from "English") if English is the default subtitle language

efb4f5ff-1298-471a-8973-3d47447115dc commented 2 weeks ago

this is just an example...

efb4f5ff-1298-471a-8973-3d47447115dc commented 2 weeks ago

Could you elaborate some more on the flaw you are seeing in this fallback strategy