So this one was a weird one to investigate and I'm still not sure how any of the things are connected but this seems to fix it. The crashlog says that it crashed in an sqlite function, it only crashes with the on-screen keyboard in Windows but not with physical ones, it only happens with the main search bar not the Invidious instances one despite both having search suggestions and the fix is removing some invalid HTML?
The list attribute on the <input> element is meant to contain the ID of a <datalist> element, in FreeTube we were pointing it to the ID of a <ul> element. This seems to cause problems with the on-screen keyboard in Windows, no idea why that invalid HTML crashes the entire page with the on-screen keyboard but has zero impact with a physical keyboard.
As I don't have access to a Mac, I haven't be able to confirm if this fixes the crash that macOS users were mentioning on that issue or if it is unrelated.
Fix search box crash
Pull Request Type
Related issue
Description
So this one was a weird one to investigate and I'm still not sure how any of the things are connected but this seems to fix it. The crashlog says that it crashed in an sqlite function, it only crashes with the on-screen keyboard in Windows but not with physical ones, it only happens with the main search bar not the Invidious instances one despite both having search suggestions and the fix is removing some invalid HTML?
The
listattribute on the<input>element is meant to contain the ID of a<datalist>element, in FreeTube we were pointing it to the ID of a<ul>element. This seems to cause problems with the on-screen keyboard in Windows, no idea why that invalid HTML crashes the entire page with the on-screen keyboard but has zero impact with a physical keyboard.https://developer.mozilla.org/en-US/docs/Web/HTML/Element/input#list
Testing
As I don't have access to a Mac, I haven't be able to confirm if this fixes the crash that macOS users were mentioning on that issue or if it is unrelated.
Desktop