Fix 'shaka-video-container' class being removed from video container
Pull Request Type
[X] Bugfix
[ ] Feature Implementation
[ ] Documentation
[ ] Other
Related issue
further resolves #5838
Description
When Vue adds dynamic classes to the video container for full window mode or forcing a 16:9 aspect ratio, the shaka-video-container class is inadvertently removed from the video container element.
Because the upstream CSS that hides the cursor is applied to .shaka-video-container.no-cursor, this results in the cursor no longer hiding when viewing 4:3 aspect ratio videos or after toggling full window mode on any video.
Screenshots
Testing
Before fix:
View a 4:3 aspect ratio video or toggle full window mode on any video, see that theshaka-video-container class is improperly removed from the video container element and that the cursor is not properly hidden.
After fix:
View a 4:3 aspect ratio video or toggle full window mode on any video, see that theshaka-video-container class remains and that the cursor is properly hidden.
Fix 'shaka-video-container' class being removed from video container
Pull Request Type
Related issue
further resolves #5838
Description
When Vue adds dynamic classes to the video container for full window mode or forcing a 16:9 aspect ratio, the
shaka-video-containerclass is inadvertently removed from the video container element.Because the upstream CSS that hides the cursor is applied to
.shaka-video-container.no-cursor, this results in the cursor no longer hiding when viewing 4:3 aspect ratio videos or after toggling full window mode on any video.Screenshots
Testing
Before fix: View a 4:3 aspect ratio video or toggle full window mode on any video, see that the
shaka-video-containerclass is improperly removed from the video container element and that the cursor is not properly hidden.After fix: View a 4:3 aspect ratio video or toggle full window mode on any video, see that the
shaka-video-containerclass remains and that the cursor is properly hidden.Desktop
Additional context