search

FreeTubeApp / FreeTube

An Open Source YouTube app for privacy
https://freetubeapp.io/
GNU Affero General Public License v3.0
13.63k stars 861 forks source link

Fix cursor hiding when first opening video #6135

Closed OothecaPickle closed 4 days ago

OothecaPickle commented 1 week ago

Fix cursor hiding when opening video

Pull Request Type

Related issue

further resolves #5838 fixes cursor hiding in the first case of @geominorai's comment

Description

Adds the no-cursor class to the video container during initialization. This fixes scenarios wherein the cursor would not be hidden if it was within the video container area before the player finished loading.

Screenshots

Testing

Click on a video on the subscriptions page such that the cursor will be in the video player area when the video loads (without moving the cursor after clicking), observe that the cursor is properly hidden.

Desktop

Additional context

I don't know how to go about fixing cursor hiding when the cursor is over the seek bar, it might be best to comment about that issue upstream.

absidue commented 1 week ago

@OothecaPickle Also please try avoiding linking the FreeTube and shaka-player repos together in the future, as shaka-player is a Google project and YouTube is a Google service and we don't need to call more attention to FreeTube than there already is.

OothecaPickle commented 1 week ago

@OothecaPickle Also please try avoiding linking the FreeTube and shaka-player repos together in the future, as shaka-player is a Google project and YouTube is a Google service and we don't need to call more attention to FreeTube than there already is.

I understand, I'll refrain from doing so in the future.

absidue commented 1 week ago

I haven't tested this pull request yet, but as it always adds that class it will likely hide the cursor even when auto-play is disabled, which means it will be paused and the controls visible (which is when the cursor should be visible too).

OothecaPickle commented 1 week ago

I haven't tested this pull request yet, but as it always adds that class it will likely hide the cursor even when auto-play is disabled, which means it will be paused and the controls visible (which is when the cursor should be visible too).

When a video is paused, shaka already does hide the cursor after a few seconds, while leaving the controls visible.