FreeTubeApp / FreeTube

An Open Source YouTube app for privacy
https://freetubeapp.io/
GNU Affero General Public License v3.0
13.63k stars 861 forks source link

Added buttons to hide hidden channels/text #6156

Open JL0000 opened 1 week ago

JL0000 commented 1 week ago

Added buttons to hide hidden channels/text

Pull Request Type

Related issue

closes #5652

Description

Screenshots

Before before After after

Testing

Settings persist after closing the application.

Desktop

Additional context

efb4f5ff-1298-471a-8973-3d47447115dc commented 1 week ago

Errors when entering the settings page and using the toggles

https://github.com/user-attachments/assets/6617e03d-b447-44b3-a208-aaf146eab197

JL0000 commented 6 days ago

Fixed it.

PikachuEXE commented 5 days ago

I think the label reads a bit confusing to me Show Hidden Channels at first I thought it was disabling hiding channels then I read Show Hidden Text. I think it would be better to label them as something like "show all already entered list of channels/text" (Not sure what exact words to use) Or move the controls below each text input field (though not the best position I guess) so users can relate that control to the list of videos/texts

JL0000 commented 14 hours ago

What do you think about List Hidden Channels and List Hidden Words?

PikachuEXE commented 6 hours ago

Show Stored/Saved Hidden Channels & Show Stored/Saved Hidden Keywords? Weird to see List...

JL0000 commented 6 hours ago

Because I name this section Content Filter I think Show Channels Added to Content Filter and Show Keywords Added to Content Filter works well. If content filter is vague, then Show Stored Hidden Channels and Show Stored Hidden Keywords works well too.

PikachuEXE commented 6 hours ago

Show Added Channels + Show Added Keywords? Assuming they are under heading Content Filter