Open JL0000 opened 1 week ago
PikachuEXE
commented
1 week ago Even though it feels kind of working for desktop Reducing padding for buttons is bad for mobile users (touch screen users more precisely) Functionality works but UI needs to be improved but I have no idea what would be good
absidue
commented
1 week ago I agree with @PikachuEXE here, maybe it would be better suited inside the dropdown?
JL0000
commented
1 week ago Didn't know it was available on mobile. What's the best way to test on mobile?
JL0000
commented
1 week ago @absidue I think putting it in the dropdown menu would make it too cumbersome to use this feature.
absidue
commented
1 week ago If you don't want to move it to the dropdown where the rest of the options are then you'll have to stick with your current solution but undo the change to shrink the buttons.
efb4f5ff-1298-471a-8973-3d47447115dc
commented
1 week ago I think that we shouldn't put this in the dropdown and keep this as is.
Some differences im seeing compared to https://github.com/FreeTubeApp/FreeTube/issues/3900#issuecomment-2220157513
title moves around on hover
https://github.com/user-attachments/assets/682353a0-5f84-490f-8f85-68cd3dcbdb0e
button has different sizes
https://github.com/user-attachments/assets/aa0f7f1e-01bd-4eab-8ca9-e3c1ca0ad02a
JL0000
commented
6 days ago @efb4f5ff-1298-471a-8973-3d47447115dc I see the title also moving on hover in https://github.com/FreeTubeApp/FreeTube/issues/3900#issuecomment-2220157513? About the button size, in the DeArrow extension there are two different button sizes.
https://github.com/user-attachments/assets/f5e4dda9-e18d-40c4-96b4-36feb6f1ea28
JL0000
commented
6 days ago I have changed back the button padding to its original size.
Thinking of adding a new setting in the DeArrow setting to enable this toggle to see original title/thumbnail.
efb4f5ff-1298-471a-8973-3d47447115dc
commented
6 days ago I think https://fontawesome.com/icons/circle-dot?f=classic&s=solid is a better representation of the DeArrow button that is used on the YT side.
Dot enabled color should be based on the secondary color theme Dot disabled should be grey
https://github.com/user-attachments/assets/f46c31bd-ec3b-4ca4-8795-5fd29591139e
Title moves around on hover
https://github.com/user-attachments/assets/2ff63924-c0e3-4d00-ad81-01f889319c3e
Doenst hover here
https://github.com/user-attachments/assets/cd8d80bb-1f10-4b59-b48b-fda6b77e8b25
Added Button to Show Original Title and Thumbnail for DeArrow
Pull Request Type
Related issue
closes #3900
Description
If DeArrow is enabled for title or/and thumbnail, when hovering over the video info area, a button is added next to the video title when the video is part of a list. This button switches the title or/and thumbnails back to its original version and vice versa.
Video
https://github.com/user-attachments/assets/61abcf2c-d1b3-42ae-b0be-fa1e667c2733
Testing
Desktop
Additional context