Dirent.path was removed in this Node.js commit https://github.com/nodejs/node/commit/d9540b51ebc1a97bbb109fff0825c2f0090aefa2 it hasn't been released yet but when it does it will break this script, so I'm updating the script now already so we don't have to wonder later why the production (nightly, release etc) builds are failing.
Testing
yarn run pack (don't leave out the run part, otherwise you'll just get a tar.gz npm bundle)
npx prettier@2.8.8 --write --no-config dist/main.js, prettier is more forceful than other formatters which is why I used it to make the mimified file readable (prettier 3 silently fails on the command line, which is why I explicitly specified the last version of v2)
Use dirent.parentPath instead of deprecated .path
Pull Request Type
Description
Dirent.pathwas removed in this Node.js commit https://github.com/nodejs/node/commit/d9540b51ebc1a97bbb109fff0825c2f0090aefa2 it hasn't been released yet but when it does it will break this script, so I'm updating the script now already so we don't have to wonder later why the production (nightly, release etc) builds are failing.Testing
yarn run pack(don't leave out therunpart, otherwise you'll just get a tar.gz npm bundle)npx prettier@2.8.8 --write --no-config dist/main.js, prettier is more forceful than other formatters which is why I used it to make the mimified file readable (prettier 3 silently fails on the command line, which is why I explicitly specified the last version of v2)/static/indist/main.jsDesktop