search

FreeTubeApp / FreeTube

An Open Source YouTube app for privacy
https://freetubeapp.io/
GNU Affero General Public License v3.0
13.63k stars 861 forks source link

Migrate CommentSection to the composition API #6211

Open absidue opened 9 hours ago

absidue commented 9 hours ago

Migrate CommentSection to the composition API

Pull Request Type

Description

This pull request migrates the CommentSection component to the composition API. The component was renamed from watch-video-comments to CommentSection as it is used on both the Watch and Post pages.

Testing

Please test loading comments on both API backends, as well as loading more comments, loading replies and loading more replies. Occasionally Invidious will return a HTTP 429 error when the instance is ratelimited by YouTube, that is unrelated to this pull request.

Posts are only supported with the Invidious API but will work with the local API set as the primary API if backend fallback is enabled.

Desktop

ChunkyProgrammer commented 8 hours ago

Would we want to use a different name than WatchVideoComments since it's also for Post comments? (I didn't rename it when I added post comments to avoid conflicts with the Piped PR but public piped instances aren't really functional anymore so the Piped PR is taking a backseat for now)

absidue commented 8 hours ago

Sure what about either of these two names: FtComments or CommentSection? Or anything else you can come up with.

ChunkyProgrammer commented 8 hours ago

Either FtComments or CommentSection work for me :)

absidue commented 8 hours ago

Done!