search

FreeTubeApp / FreeTube

An Open Source YouTube app for privacy
https://freetubeapp.io/
GNU Affero General Public License v3.0
13.37k stars 825 forks source link

Highlighting comments #783

Open efb4f5ff-1298-471a-8973-3d47447115dc opened 3 years ago

efb4f5ff-1298-471a-8973-3d47447115dc commented 3 years ago

Is your feature request related to a usage problem(not a bug?) In YT when u go to the comment section and click on the comment time stamp (timestamp is next to the username in FreeTube) for example 1 Day ago then the comment gets highlighted and get pinned to the top of the comment section even when u close the vid and come back later to rewatch. This would be handy because if u want to rewatch the video the valuable information is still pinned at the top.

Describe the solution you'd like to see implemented Click on the timestamp to highlight and dehighlight a comment. Highlighted comments have priority over pinned ones by the channel owner.

Describe alternatives you've considered None.

Screenshots

https://user-images.githubusercontent.com/73130443/104846583-2c545480-58d3-11eb-9b8e-190066656958.mp4

Additional context None.

GilgusMaximus commented 3 years ago

Quite a good idea. This could be done by a new contributor, who wants to do it. You'll get a lot of insight into a lot of different areas of the code.

To implement this, it is required to add an event to the comments which listens for a click. Additionally a new table in the database is required, because the comment information (author, date of publish, text, likes,...) and the videoId are stored. And the data from the database is fetched when you load the comments and the videoId matches any comments.

tiwarys commented 3 years ago

@efb4f5ff-1298-471a-8973-3d47447115dc

In YT when u go to the comment section and click on the comment time stamp (timestamp is next to the username in FreeTube) for example 1 Day ago then the comment gets highlighted and get pinned to the top of the comment section even when u close the vid and come back later to rewatch.

I'm not able to understand how we can highlight a comment in YouTube. Could you explain in detail. GIF or video is highly appreciable. Does above method of highlighting a comment work on both YouTube website and YouTube app?

efb4f5ff-1298-471a-8973-3d47447115dc commented 3 years ago

Here is a video for u :)'

https://user-images.githubusercontent.com/73130443/104846583-2c545480-58d3-11eb-9b8e-190066656958.mp4

I dont know if this works on the app. It does work on the website.

tiwarys commented 3 years ago

Thanks for the video. I don't know about this feature till now.

tiwarys commented 3 years ago

@GilgusMaximus In YouTube website we can only Highlight one comment per video. When this feature is implemented in Freetube allow users to highlight more than 1 comment on a video.

GilgusMaximus commented 3 years ago

Sure. This should be no problem. Once the storing and loading is implemented, there really is no limit other than your disk size

ab-shrek commented 12 months ago

I would like to take up this task. Can you assign this to me @GilgusMaximus; please?

efb4f5ff-1298-471a-8973-3d47447115dc commented 12 months ago

Hi @ab-shrek i assigned u

ab-shrek commented 11 months ago

Came up with an initial patch although it does not handle removing the highlight from a comment. Is that something that you guys feel should be allowed too? In youtube, you can only highlight one comment, but this change intends to allow multiple comments to be highlighted for a video. This can easily increase over time. Can send out a patch to disable highlights on clicking again too once the sent out patch looks fine.

efb4f5ff-1298-471a-8973-3d47447115dc commented 11 months ago

I think the initial PR should handle adding and removing on at least one highlight comment for each channel