search

FreeTubeApp / FreeTube

An Open Source YouTube app for privacy
https://freetubeapp.io/
GNU Affero General Public License v3.0
12.91k stars 798 forks source link

Verified mark(Right mark) beside channel name #944

Open tiwarys opened 3 years ago

tiwarys commented 3 years ago

Is your feature request related to a usage problem (not a bug)? Please describe.

Suppose if I want to check whether a YouTube channel is verified or not, there is no way to do it.

Describe the solution you'd like to see implemented

I think it would be nice if you add Verified mark(Right mark) beside channel name as youtube website does.

Describe alternatives you've considered

In YouTube website we can whether a channel has verified mark or not.

Screenshots

Screenshot from YouTube website

Verification mark

Additional context

Verified mark beside channel name helps in deciding whether channel is authentic or not.

GilgusMaximus commented 3 years ago

Hi, so fortunately, someone over at the modules repo added this a few days ago. So the data is there already. As for #917 , this should be rather easy to add. So if someone wants to get started, we are open for contributions, and happy to help :)

lambdaclan commented 3 years ago

Hello @GilgusMaximus I will start working on this ticket :+1:

efb4f5ff-1298-471a-8973-3d47447115dc commented 1 year ago

@ChunkyProgrammer you're still assigned to this. Maybe want to deassign?

Benjababe commented 11 months ago

I'm interested in working on this, could I be assigned to it?

efb4f5ff-1298-471a-8973-3d47447115dc commented 11 months ago

@Benjababe assigned! U maybe can take a look at a previous attempt https://github.com/FreeTubeApp/FreeTube/pull/1821

Benjababe commented 10 months ago

To the people of the future and in case I forget about it:

Without doing all the channel caching, currently invidious doesn't support authorVerified for the popular and video api (invidiousGetVideoInformation in Watch.js and fetchPopularInfo in Popular.js). Keep an eye on this https://github.com/iv-org/invidious/issues/3323

Local API seems to work fine for all pages and keeps close with YouTube where it displays the verified mark.

Shorts never share any verified flags as in YouTube they don't show the channel name so I shouldn't worry about it so much.

efb4f5ff-1298-471a-8973-3d47447115dc commented 9 months ago

Hi @Benjababe just checking in, what is the status of this? Are you in need of some help?

Benjababe commented 9 months ago

@efb4f5ff-1298-471a-8973-3d47447115dc Haven't touched it in a while but the changes still work just through random browsing. Invidious doesn't include the verified info in 2 places, waiting for them to be added before making the PR.

  1. Popular page image image

  2. Recommended videos image image

ChunkyProgrammer commented 4 months ago

Hi @Benjababe , I opened a PR to add it to the recommended videos. For the popular endpoint, I think it'd be okay to not include that for now (it would require Invidious to make a database change so it likely won't happen for a while

ChunkyProgrammer commented 3 months ago

Should be included in recommended videos for Invidious now