FreeUKGen / FreeBMD2

For everything related to FreeBMD2. An updated version of the original FreeBMD genealogy website.
Apache License 2.0
1 stars 0 forks source link

BMD and CEN (patchy implementation) need per-page title elements, as on REG #515

Open AlOneill opened 2 years ago

AlOneill commented 2 years ago

Although REG sets the title element in the head on a per page basis, BMD and CEN do not.

The BMD default title is misleading as it says, "FreeBMD - UK Birth, Marriage, and Death Records (England, Scotland, Wales)". The emphasis is mine — Scotland records are not included on BMD.

AlOneill commented 2 years ago

The contents of the title element is the first thing a screen reader user will hear when they reach a page. It helps everyone to know what the page is about, and whether they are in the right place. Sighted users will expect to see that in the browser tab. When a user returns to a browser tab later, they will know which page they are on.

For sighted users with a lot of tabs open, it helps to put the site name last — the tab icon will be enough for many to identify the site. For example, "Accessibility statement | FreeBMD". This is the pattern on REG.

DeniseColbert commented 2 years ago

@Vino-S will look at the code for FreeREG and see if it can be taken over to CEN & BMD2

Vino-S commented 2 years ago

CEN: Ready for testing in test3 CEN

AlOneill commented 2 years ago

@Vino-S looking good, but should be cased as "FreeCEN" rather than "FREECEN" and I'm not sure that app pages have the most useful titles — I will need to make a more thorough check.

DeniseColbert commented 2 years ago

Vino will fix casing

PatReynolds commented 2 years ago

Done now on FreeCEN, but casing needing attention.

AlOneill commented 2 years ago

@Vino-S Casing CEN now looks good but am not seeing update on BMD

PatReynolds commented 2 years ago

Moved to production, so closing.

AlOneill commented 2 years ago

Still not seeing title element contents in browser tab on BMD t3 — re-opening.

richardofsussex commented 2 years ago

I'm not sure where this issue has got to, but the fix is to update this code in app/helpers/application_helper.rb (line 369 onwards): def project_description { freereg: "UK Parish Register Records", freecen: "UK Census Records (England, Scotland, Wales)", freebmd: "UK Birth, Marriage, and Death Records (England, Scotland, Wales)" } end

AlOneill commented 2 years ago

@richardofsussex For FreeBMD, we do not have records for Scotland, but you knew that already :-), so:

def project_description { freereg: "UK Parish Register Records", freecen: "UK Census Records (England, Scotland, Wales)", freebmd: "UK Birth, Marriage, and Death Records (England, Wales)" } end

or something similar.

In addition, pages other than the search page will need their own version of the title text as used for FreeREG pages.

AlOneill commented 2 years ago

There remains an issue with some of the title elements: whilst doing something else I noticed that the page I was looking at had <title>String | BMD</title> — oops.

The h1 for the page was, "Entries in Page: 288, Volume: 8 at District: Wimborne for Apr to Jun 1848"

richardofsussex commented 2 years ago

I fixed this by simply adding <% title "Same page entries" %> to same_page_entries.html.erb. @Vino-S please merge the fb_473_rbl branch into test3 so @AlOneill can double-check.

Any other pages you find with a title "String | BMD" can be fixed in the same way.

DeniseColbert commented 1 year ago

@Vino-S please check Richard's comment and if it's right, push into test3 so @AlOneill can check

DeniseColbert commented 1 year ago

@AlOneill to test on test3

DeniseColbert commented 1 year ago

@AlOneill is this done now?

AlOneill commented 1 year ago

@DeniseColbert I do not completely understand how the contents of each title element is set up for the app pages — I hope that it can be set up to be automatic because we do not use a distinct page setup for each instance but rather a template, if you see what I mean? However, I can let the developers know of pages that I come across that do not have a fully-formed title element and maybe they can look at the pages themselves and devise a fix for any that are incomplete?

For instance, I checked the Records page: it is incomplete as it reads "FreeBMD |" whereas a complete title for the top-level Records page would be "Records | FreeBMD".

On selecting "B" I would hope for a title of "Districts starting with B | FreeBMD"; then on selecting Banbury, the title would be "Banbury District Information | FreeBMD". In other words, the title should be specific to the page — it cannot be "Records | FreeBMD" for every page in the Records section, however tempting that might be!

TBH, I would have to check, but I do not believe that the title elements are properly specific on FreeREG or FreeCEN. We need to fix them too. Sorry, developers if this looks like a faff, but it is important (even essential) for some of our users and helpful for all our users.

AlOneill commented 1 year ago

@DeniseColbert REG title elements situation is looking better than I expected, but there are still some oddities. (I have run out of steam.)

DeniseColbert commented 1 year ago

Is BMD in line with REG? Probably not, but let's find out what's needed.

DeniseColbert commented 1 year ago

@AlOneill please test on test3 when Vino updates the comments with the changes she has made