Open richardofsussex opened 8 months ago
It looks as though there are two variants within BestGuessHash
: bmd1_show.html.erb
and show.html.erb
. as well as the 'default' page which is defined in BestGuess
; also show.html.erb
.
A single saved record has a similar Entry information display to the standard search results one, but lacks the More information row:
I suggest checking whether the page follows the wireframe design. For example, buttons 'Back to results' and 'Generate citation' should be aligned to the left side of the page. The fields in the table need to be done according to the wireframe. (We have separate stories for this)
consider aligning text left if it helps with the presentation of the records to the Researchers.
Consider updating the envelope image within the postem row to read 'Add a postem'.
Nuri, thank you for your comments. I have added a point about the envelope to story #595. I can also add the text alignment, @richardofsussex @DeniseColbert, what do you think?
@nurifreembd Nuri, I'm sorry, I forgot that we have changed the Postems view and have a different implementation on test 3. On test 3 there is 'Postems', and when you click on it, the option 'Add a postem' appears. Could please have a look at test 3?
Checked on test3, when you hover over the envelope it reads postems. On click it reads postems loading then launches the following message
We're sorry, but something went wrong with processing your request. A report has been produced and sent to the webmaster. Please return to your prior activity but try to avoid doing the exact same action again.
On Thu, Nov 21, 2024 at 9:11 PM KristinaGadzhieva @.***> wrote:
@nurifreembd https://github.com/nurifreembd Nuri, I'm sorry, I forgot that we have changed the Postems view and have a different implementation on test 3. On test 3 there is 'Postems', and when you click on it, the option 'Add a postem' appears. Could please have a look at test 3?
— Reply to this email directly, view it on GitHub https://github.com/FreeUKGen/FreeBMD2/issues/564#issuecomment-2492343120, or unsubscribe https://github.com/notifications/unsubscribe-auth/BDP72B7CGGLQN7CCOGAI4ML2BZEBJAVCNFSM6AAAAABESSFXK6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDIOJSGM2DGMJSGA . You are receiving this because you were mentioned.Message ID: @.***>
The standard Entry information page, as displayed from search results:
does not look the same as, or contain the same information as, the Entry information page which is displayed when you enter the 'hash URL' (e.g. http://localhost:3000/entry-information/9Llytp0ZnMt2i7KwdA5uZA/hash):
There may be other variants of the Entry information page elsewhere in the BMD2 ecosystem: @Vino-S can advise. I think they should all have the same design and information content, unless there are clear reasons for them to vary. Ideally they should (for ease of maintenance in future) all be generated from the same code.