FreeUKGen / FreeCENMigration

Issue tracking for project migrating FreeCEN to FreeCEN2 genealogy record database and search engine architecture. Code developed here is based on that developed in MyopicVicar
https://www.freecen.org.uk
Apache License 2.0
4 stars 3 forks source link

Records: accessibility issues #1380

Open AlOneill opened 2 years ago

AlOneill commented 2 years ago

The Records page looks very good — very neat — but it has a number of issues related to display and accessibility.

Many of the issues on this page are inter-related, that is they need to solved together and the nature of the fix will determine the details. So, where to start? Fixing the table issues could be a good place.

Other issues:

Issues that need policy decisions:

AlOneill commented 2 years ago

@AnneV-Learn Accessibility is a multi-faceted thing and automatic testing will only pick up about 30% of the issues. You have made a commendable attempt!

PatReynolds commented 2 years ago

@AnneV-Learn to take a look and get back to @AlOneill

AnneV-Learn commented 2 years ago

@AlOneill Sorry this took so long, I got caught up with other issues. I have made corrections (see below) and you can now review on Test3.

Round 1 Corrections:

once the legends are gone, review the headings

Other issues: the opening page is not fully responsive — the columns start to overlap on screens that are a bit wider then palm. Review once the non-semantic fieldsets are gone. - Seems ok to me now. surely it is the presence of years (rather than brackets) in the Place select that is important? S-R users will not know that the brackets are there - re-worded using brackets with meaning will be lost on S-R users who will not know they are there. (In some displays the space is missing between the Civil Parish name and the list of hamlets, etc.) - this is a feature of the way this data is held in the database “You may view the Database Records for …” is ambiguous, even misleading - re-worded there is no need to put the top heading in a grid grid__item, unless the grid is inherited from a partial? - Addressed I hope(?)

AlOneill commented 2 years ago

@AnneV-Learn First, apologies for some misleading descriptions of the issues — I've amended those. The description of how to use the scope attribute is entirely my fault. I've only just become aware that the initial description of how to use the caption element is flawed — unfortunately, there is a lot of misinformation out there, but actually using a screen reader is very revealing.

I'm going to look at your changes, make some notes, and then we can tackle the next round of improvements. So far so good. Thank you!

AnneV-Learn commented 2 years ago

Updates made and deployed to Test3 for second round of assessment by @AlOneill

AlOneill commented 2 years ago

@AnneV-Learn has made accessibility improvements to the main Records page (all counties) and the page for a single county.

We will be moving on next to fix a few additional things on the page for a single Place. After that, we will tackle the displays that list Pieces and Names.

PatReynolds commented 2 years ago

@AnneV-Learn to contact Alison about restarting (and redeploy code to test 3)

DeniseColbert commented 2 years ago

@AnneV-Learn to review Names letter selection in terms on in-page navigation rather than a new page load

AnneV-Learn commented 2 years ago

I am not totally convinced that switching to in-page navigation for presenting the unique names filtered by initial letter is the way to go:

AlOneill commented 2 years ago

Interesting. Time was never my main concern here.

AnneV-Learn commented 2 years ago

Ok @AlOneill - I have made changes to the Names page (in-page navigation, the names are now in 'lists' and there are 'Back to top of page' links). This may still not be completely what you want but hopefully it is on the right track. It has been deployed to Test3 (along with re-instating the changes that were already made to address accessibility issues).

AlOneill commented 2 years ago

@AnneV-Learn I've had a quick look at a Surnames page and it is three steps in the right direction. Well done.

I was a little disappointed to see an isolated <li class="grid"> :-( especially as it visibly throws the whole page out of kilter. And BTW, there is no such element as an <nl> !!

It will take me a few days at least to work through the page (my personal batteries are very depleted) and make some sensible suggestions for improvement — I do not want to give you suggestions with duff side-effects and there is a lot to pull together on a page such as this.

AnneV-Learn commented 1 year ago

Updates to Place Names page provided by Alison implemented on Test3

DeniseColbert commented 1 year ago

@AlOneill to test