FreeUKGen / FreeCENMigration

Issue tracking for project migrating FreeCEN to FreeCEN2 genealogy record database and search engine architecture. Code developed here is based on that developed in MyopicVicar
https://www.freecen.org.uk
Apache License 2.0
4 stars 3 forks source link

Link to Gazetteer in main menu and on "Your actions" page have an accessibility issue #1462

Closed AlOneill closed 4 months ago

AlOneill commented 1 year ago

The information that the Gazetteer will open in a new tab is buried in a title attribute which means that any user who cannot hover (because they cannot or do not use a pointing device) will never see that information. The behaviour could surprise or even confuse them.

This issue will probably be deemed of low priority, but it is our stated aim to make our sites and pages as accessible as possible to all users. The user limitations that are relevant here should not make it more difficult for a volunteer, whether transcriber or coordinator or other role, to use the site comfortably.

AlOneill commented 1 year ago

I can suggest two possible approaches here:

  1. incorporate some text into the main menu link to indicate that it will open in a new tab, e.g. "GAZETTEER (new tab)" — as this link is for members only I suggest that they will (soon!) understand that 'new tab' means that the link will open in a new tab

  2. remove target="_blank" from the link and rely on the user to open the link in a new tab (if desired) themselves

As either solution would require an adjustment in mindset for many members, we would need to explain the change for them.

Which approach would the Scrum prefer? Can anyone propose a different (better for everyone?) approach?

AlOneill commented 1 year ago

Please note that a similar situation applies to the Gazetteer link (it looks like a button but it is a link) on the "Your actions" page. A similar solution is needed, i.e. set a visible (to all) warning or remove target="_blank".

DeniseColbert commented 1 year ago

Option 2 is what we're to moving towards so for consistency we'll go with that.

i.e. remove target="_blank" from the link and rely on the user to open the link in a new tab (if desired) themselves

AlOneill commented 1 year ago

@DeniseColbert I have reviewed the link to the gazetteer on the Actions page today and note that:

The main menu item opens in a new tab but the warning is inaccessible to keyboard-only users.

DeniseColbert commented 10 months ago

@PatReynoldsFUG to test

PatReynoldsFUG commented 10 months ago

In test 3: "Button" gazatteer still says (when hovering) "opens in a new tab"

Browser tab still says 'FreeCEN |'

Same on both Test3 and live

DeniseColbert commented 10 months ago

@Vino-S to make these changes (Alison's comment from November)

geoffj-FUG commented 10 months ago

If this is going to be a choice in keeping with policy can we add a rollover to this tab that says 'right click to open in new tab' for the Gazetteer menu items please. This should stop a load of complaints from transcribers. Geoff

Vino-S commented 9 months ago

Ready for testing in test3

DeniseColbert commented 9 months ago

@PatReynoldsFUG and @geoffj-FUG to test

AlOneill commented 9 months ago

@geoffj-FUG It would not make sense to replace "Opens in new tab" with your suggestion as both are inaccessible to keyboard-only users (who cannot hover).

We should be prepared for the complaints and respond with the reason. Members will get the idea soon enough.

AlOneill commented 9 months ago

I see that the Gazetteer link in the main menu still has a title attribute and that it reads on hover: "Search for an existing place name; Right click to open in new tab".

I hope this is temporary as title attributes are not accessible to a keyboard-only user.

DeniseColbert commented 9 months ago

To ask the Accessibility team re Alison's comments

DeniseColbert commented 9 months ago

Solution suggested:

Hover text should read "Open in new tab"

Place a line of text on Gazetteer page WTTE: "You might want to have this page open in a different tab while you work. You can open it in a new tab from the navigation menu".

AlOneill commented 9 months ago

@DeniseColbert Can I remind you that "hover text" (aka text in a title attribute) is not accessible to any user who cannot hover for any reason: keyboard only, broken mouse, etc. The whole point of this issue is to eliminate "hover text".

I see what you are getting at by replacing "opens" with "open" but I fear it will be misread as "opens" and that will cause confusion. I maintain that removing the title attribute (hover text) is a better solution.

DeniseColbert commented 9 months ago

Thanks Alison: agreed, let's remove reference to that on hover to avoid confusion.

AlOneill commented 9 months ago

@DeniseColbert A compromise might be a temporary title attribute that reads "Please open in a new tab" but it must be removed in a month or so.

Vino-S commented 7 months ago

@geoffj-FUG to add comment.

geoffj-FUG commented 6 months ago

Pat

I thought this was discussed at the last scrum and that some sort of consensus had been achieved.

I don’t support the Gazetteer opening in the same tab at all. The change has been made on test3 and I continually end up with the Gazetteer overwriting my work and I have to start again. . I have washed my hands of this.

It is not my issue to resolve. I have no jurisdiction over this.

Geoff

From: Pat Reynolds @.> Sent: Tuesday, April 30, 2024 7:09 PM To: FreeUKGen/FreeCENMigration @.> Cc: Geoff J @.>; Assign @.> Subject: Re: [FreeUKGen/FreeCENMigration] Link to Gazetteer in main menu and on "Your actions" page have an accessibility issue (Issue #1462)

Assigned #1462 https://github.com/FreeUKGen/FreeCENMigration/issues/1462 to @geoffj-FUG https://github.com/geoffj-FUG .

— Reply to this email directly, view it on GitHub https://github.com/FreeUKGen/FreeCENMigration/issues/1462#event-12654816332 , or unsubscribe https://github.com/notifications/unsubscribe-auth/AKCPIFPPR5PEQZH26XLACHTY75NUHAVCNFSM6AAAAAASGUW2SKVHI2DSMVQWIX3LMV45UABCJFZXG5LFIV3GK3TUJZXXI2LGNFRWC5DJN5XDWMJSGY2TIOBRGYZTGMQ . You are receiving this because you were assigned. https://github.com/notifications/beacon/AKCPIFKT7VUML4EYS64ETTLY75NUHA5CNFSM6AAAAAASGUW2SKWGG33NNVSW45C7OR4XAZNWJFZXG5LFIV3GK3TUJZXXI2LGNFRWC5DJN5XKUY3PNVWWK3TUL5UWJTYAAAAAF4SJFRGA.gif Message ID: @. @.> >

Vino-S commented 6 months ago

Scrum decided to keep existing way: Open Gazetter in new tab @Vino-S Remove the Gazetter implementation from test3

AlOneill commented 6 months ago

I am disappointed that the Scrum decided to keep the Gazetteer link inaccessible to anyone who either cannot hover (because they navigate by keyboard) or who does not understand what has happened where a link opens in a new tab.

I was reminded this very week that the default browser behaviour is to open the link but to keep the focus on the originating tab. That was a disorienting experience for me — I wondered what had happened, what had gone wrong. It then took some digging in the browser settings to be able to change the behaviour so that the focus moved to the newly opened tab.

I hope the Scrum will reconsider the decision and reverse this backward step in improving the Accessibility of FreeCEN.

DeniseColbert commented 4 months ago

Alison to Action with some explanation on the Gazetteer page

AlOneill commented 4 months ago

@Vino-S I see an empty link in the blue box in the sidebar as part of the heading "What has changed?": <a href="/system/resources/W1siZiIsIjIwMjQvMDEvMzEvOG5sY3B3ZHN2MV9GcmVlQ0VOMl9IYW5kYm9va19wYXJ0XzFBX0phbl8yMDI0LnBkZiJdXQ/FreeCEN2-Handbook-part-1A-Jan-2024.pdf?sha=3d7fa56104267490" title="Handbook 1A"></a> Unless you tell me otherwise, I will delete this empty link. (I assume it is left over from devising the "Make a suggestion to improve the handbook" link.) Thanks.

AlOneill commented 4 months ago

@Vino-S I see another issue: you have marked up the link to "Make a suggestion …" as an aside with the same ARIA markup as the blue box, giving the link the title of "What has changed?" — oops, make that "Links and tabs". I do not think this is appropriate and so I will mark up the link in a div, without the ARIA attribute.

AlOneill commented 4 months ago

I have updated a DRAFT Handbook page on t3 with an explanation that the Gazetteer page will continue to open in a new tab, for the convenience of volunteers. See the second paragraph of "Links and tabs > What has changed?" on Draft FreeCEN Handbook

geoffj-FUG commented 4 months ago

Alison

That looks good.

Geoff

From: AlOneill @.> Sent: Friday, June 28, 2024 6:54 PM To: FreeUKGen/FreeCENMigration @.> Cc: Geoff J @.>; Mention @.> Subject: Re: [FreeUKGen/FreeCENMigration] Link to Gazetteer in main menu and on "Your actions" page have an accessibility issue (Issue #1462)

I have updated a DRAFT Handbook page on t3 with an explanation that the Gazetteer page will continue to open in a new tab, for the convenience of volunteers. See the second paragraph of "Links and tabs > What has changed?" on Draft FreeCEN Handbook https://test3.freecen.org.uk/cms/draft-freecen-handbook

— Reply to this email directly, view it on GitHub https://github.com/FreeUKGen/FreeCENMigration/issues/1462#issuecomment-2196440965 , or unsubscribe https://github.com/notifications/unsubscribe-auth/AKCPIFNDOR43APFPJA4ROILZJUQBXAVCNFSM6AAAAAASGUW2SKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCOJWGQ2DAOJWGU . You are receiving this because you were mentioned. https://github.com/notifications/beacon/AKCPIFJAF7PQBTFXK2NH233ZJUQBXA5CNFSM6AAAAAASGUW2SKWGG33NNVSW45C7OR4XAZNMJFZXG5LFINXW23LFNZ2KUY3PNVWWK3TUL5UWJTUC5MDYK.gif Message ID: @. @.> >

AlOneill commented 4 months ago

Draft page published on t3. It is sync-ready.

DeniseColbert commented 4 months ago

Should be deployed to production so closing