search

FreeUKGen / FreeCENMigration

Issue tracking for project migrating FreeCEN to FreeCEN2 genealogy record database and search engine architecture. Code developed here is based on that developed in MyopicVicar
https://www.freecen.org.uk
Apache License 2.0
4 stars 3 forks source link

Problem with assignment of freecen2_place_of_birth_id when birth_place = hyphen #1788

Closed AnneV-Learn closed 3 months ago

AnneV-Learn commented 3 months ago

This issue affects the assignment of freecen2_place_of_birth_id on Search Records when VLD files are loaded, CSV files are incorporated, VLD POB validation and the RAKE that retrospectively populated freecen2_place_of_birth_id on existing Search Records. The problem is associated with the Freecen2_lace.valid_place(county, place_name) method that goes on to check for alternative name matches even if the birth_place is a hyphen and unless the birth_county is UNK may assign a 'random' place ID for the county! Freecen2_place.valid_place(county, place_name) should return true (ie valid) and a nil place_id if the place_name is '-'. Also need to write a RAKE task to correct existing records across all counties.

AnneV-Learn commented 3 months ago

Tested on Test3 (not something that can be user tested). Ready for Deployment.

AnneV-Learn commented 3 months ago

The Rake task has been successfully run across all counties so this is now completed.