CSVProc File Upload - List of users where file to be stored includes INACTIVE users

[AnneV-Learn]

Whilst trying to resolve an issue that a coordinator and user were having with uploading/replacing a CSV file I noticed that the dropdown list of users where file is to be stored that Coords see includes INACTIVE users. I believe it should only show ACTIVE users.

[AnneV-Learn]

Fix now ready for testing on Test3

[geoffj-FUG]

Anne

Can I add a thought to that please? It should be active users within the county. But we do need an option to expand that to all active users (I have volunteers who are registered in one county but I use in other counties. Most Coordinators do.

Geoff

[AnneV-Learn]

@geoffj-FUG Does ‘registered in one county’ mean volunteers in the county syndicate that matches the Admin county of the piece or something else?

[suffolkroots]

Anne---another thought---

Sometimes we need to do a correction then replace on a file owned by an inactive ID. Therefore they should be kept in the list?

[geoffj-FUG]

Anne

I was thinking of the syndicate that matches the county of the piece.

Perhaps we should look at just active syndicate members for a county being listed (to make every day work easier). We would need an option to list everybody on the system, active and inactive to allow for contingencies. That way we can cover all options.

Geoff

From: suffolkroots @.> Sent: Friday, July 26, 2024 1:03 AM To: FreeUKGen/FreeCENMigration @.> Cc: Geoff J @.>; Mention @.> Subject: Re: [FreeUKGen/FreeCENMigration] CSVProc File Upload - List of users where file to be stored includes INACTIVE users (Issue #1795)

Anne---another thought---

Sometimes we need to do a correction then replace on a file owned by an inactive ID. Therefore they should be kept in the list?

— Reply to this email directly, view it on GitHub https://github.com/FreeUKGen/FreeCENMigration/issues/1795#issuecomment-2250604155 , or unsubscribe https://github.com/notifications/unsubscribe-auth/AKCPIFJUBEYQUNSWZ4J3O5DZOEHSHAVCNFSM6AAAAABKH5SV6CVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDENJQGYYDIMJVGU . You are receiving this because you were mentioned. https://github.com/notifications/beacon/AKCPIFN6ASGL2UL2I56UDOTZOEHSHA5CNFSM6AAAAABKH5SV6CWGG33NNVSW45C7OR4XAZNMJFZXG5LFINXW23LFNZ2KUY3PNVWWK3TUL5UWJTUGEV7HW.gif Message ID: @. @.> >

[AnneV-Learn]

@geoffj-FUG Maybe the best thing to do (since no one has actually complained about anything here) would be to just limit the change to the code so that ALL Users are listed if it is a REPLACE upload and only ACTIVE Userids are listed if it is a NEW upload.

[geoffj-FUG]

Anne

I think that it is a case of the devil we do and the devil we don’t.

Let’s put it on ice and get on with more important things. These niggles only serve to distract us from what we should be doing.

Geoff

From: Anne Vandervord @.> Sent: Friday, August 2, 2024 8:24 PM To: FreeUKGen/FreeCENMigration @.> Cc: Geoff J @.>; Mention @.> Subject: Re: [FreeUKGen/FreeCENMigration] CSVProc File Upload - List of users where file to be stored includes INACTIVE users (Issue #1795)

@geoffj-FUG https://github.com/geoffj-FUG Maybe the best thing to do (since no one has actually complained about anything here) would be to just limit the change to the code so that ALL Users are listed if it is a REPLACE upload and only ACTIVE Userids are listed if it is a NEW upload.

— Reply to this email directly, view it on GitHub https://github.com/FreeUKGen/FreeCENMigration/issues/1795#issuecomment-2265061039 , or unsubscribe https://github.com/notifications/unsubscribe-auth/AKCPIFMREXBCWIES5UP7WZ3ZPNM3DAVCNFSM6AAAAABKH5SV6CVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDENRVGA3DCMBTHE . You are receiving this because you were mentioned. https://github.com/notifications/beacon/AKCPIFMRMG2AYXGAQJMNGWTZPNM3DA5CNFSM6AAAAABKH5SV6CWGG33NNVSW45C7OR4XAZNMJFZXG5LFINXW23LFNZ2KUY3PNVWWK3TUL5UWJTUHAILK6.gif Message ID: @. @.> >

[AnneV-Learn]

@geoffj-FUG Agreed.