search

FreeUKGen / FreeCENMigration

Issue tracking for project migrating FreeCEN to FreeCEN2 genealogy record database and search engine architecture. Code developed here is based on that developed in MyopicVicar
https://www.freecen.org.uk
Apache License 2.0
4 stars 3 forks source link

Channel Islands place of birth searches do not work #272

Closed PatReynolds closed 7 years ago

PatReynolds commented 7 years ago

A search for John Smith in the 1891 census finds 1 record when place of birth is Jersey, but no records if place of birth is Channel Islands.

A search for Channel Islands should not find Isle of Man (or we need to change the name to Crown Dependencies).

dougkdev commented 7 years ago

fix on test2

dougkdev commented 7 years ago

deployed to production, ready for user test

PatReynolds commented 7 years ago

Error message about not finding without forename on 'all counties' also occurs on Channel Islands and Worcestershire.

dougkdev commented 7 years ago

Currently the query form imposes the same restriction as Reg in that if you search across all counties (census counties) a first and last name are required. Are you saying that we should change that requirement so that if EITHER a census county OR a birth county is specified we no longer require both a first and last name? Or are you just saying the error message is unclear and we should change it to specify that the forename requirement is for searches of all census counties?

helhyde commented 7 years ago

If you select Channel Islands for birth, and all counties for Census, it says you have to have a surname and a first name. If you select Anglesea for birth, and all counties for Census, it performs the search.

On 2 August 2017 at 01:16, dougkdev notifications@github.com wrote:

Currently the query form imposes the same restriction as Reg in that if you search across all counties (census counties) a first and last name are required. Are you saying that we should change that requirement so that if EITHER a census county OR a birth county is specified we no longer require both a first and last name? Or are you just saying the error message is unclear and we should change it to specify that the forename requirement is for searches of all census counties?

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/FreeUKGen/FreeCENMigration/issues/272#issuecomment-319531971, or mute the thread https://github.com/notifications/unsubscribe-auth/ANXTHTivtFbcexmIq0U_JCgzwaKnZn0lks5sT7_IgaJpZM4OOkYh .

-- - -

Dr Pat Reynolds Executive Director Free UK Genealogy http://www.freeukgenealogy.org.uk/ A Charitable Incorporated Organisation registered in England and Wales, number 1167484 VAT registration: 233 0105 70

​+44 ​1723 362616 ​ +44 7943 145387 Westwood House,Westwood, Scarborough YO11 2JD, UK

dougkdev commented 7 years ago

I'm not seeing the same thing as you are. On both test2 and production if I use only surname Smith (no first) I get the message with both Anglesea and Channel Islands for birth and All counties for census. I don't see the message and search is performed when first name is included.