search

FreeUKGen / FreeCENMigration

Issue tracking for project migrating FreeCEN to FreeCEN2 genealogy record database and search engine architecture. Code developed here is based on that developed in MyopicVicar
https://www.freecen.org.uk
Apache License 2.0
4 stars 3 forks source link

Merge emendation list code from FreeREG #289

Closed PatReynolds closed 6 years ago

PatReynolds commented 7 years ago

Brenda reports: Just done a search using YKS only for a David Smith. POB 1800 to 1890 All Census Years Because I selected YKS as the Census County it did not give me a choice of Census places. It did however give me 205 results If I search for Dave I get nil results Are we using the FreeREG emendation list on FreeCEN2?
On FreeCEN1 1891 'Dave Smith' only finds 1 record (total UK). On FreeCEN2 the search finds one in 1871, one in this form in 1891, and also 'Alfred Dave John SMITH'

benwbrum commented 7 years ago

Most of our emendation rules only handle abbreviations ("Tho" for "Thomas") rather than nicknames ("Tom" for "Thomas"), so I'm not surprised that Dave isn't one we apply. We really should be listing the rules we support, however, and documenting them for researchers.

Ben

On Tue, Aug 1, 2017 at 4:24 AM, PatReynolds notifications@github.com wrote:

Brenda reports: Just done a search using YKS only for a David Smith. POB 1800 to 1890 All Census Years Because I selected YKS as the Census County it did not give me a choice of Census places. It did however give me 205 results If I search for Dave I get nil results Are we using the FreeREG emendation list on FreeCEN2? On FreeCEN1 1891 'Dave Smith' only finds 1 record (total UK). On FreeCEN2 the search finds one in 1871, one in this form in 1891, and also 'Alfred Dave John SMITH'

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/FreeUKGen/FreeCENMigration/issues/289, or mute the thread https://github.com/notifications/unsubscribe-auth/AAMNGawo1K__YNUboom8W_N2i1-lklGBks5sTu7cgaJpZM4OpdMg .

-- Ben W. Brumfield Partner. Brumfield Labs LLC Creators of FromThePage https://fromthepage.com/

benwbrum commented 6 years ago

This may be picked up automatically thanks to #408. This will be a testing task once that is resolved.

richpomfret commented 6 years ago

Should be ready to test?

benwbrum commented 6 years ago

Yes it should be ready for testing.

PatReynolds commented 6 years ago

Can the initial problem be replicated?

richpomfret commented 6 years ago

@PatReynolds to try and replicate.

PatReynolds commented 6 years ago

Thos does not find Thomas, Thomas find Thos (i.e. working correctly). David does not find Dave on FC2 (working correctly). David does not find Dave on FC1. Therefore: is this a request to expand the emmendation list to include abbreviations such as Tommy, Dick and Harry, or can it be closed, @FreecenBren ?

FreecenBren commented 6 years ago

The example Dave is a difficult one as I have no recollection of having seen Dave, always David. That does not mean there was none. I think possibly Dave is more a 20th Centuary variation. I just did a search on FC2 with the name Dave Smith and nothing else selected, and from 30 million plus records it found 3.

We could possibly end up with so many emendations and not many found anyway. Incidently I did the same search for Tommy Smith and also got 3 found. So % wise 3 from 35 million records online.

More thought I think! My thought though is to close it.

On Wed, 11 Jul 2018 at 11:35, PatReynolds notifications@github.com wrote:

Thos does not find Thomas, Thomas find Thos (i.e. working correctly). David does not find Dave on FC2 (working correctly). David does not find Dave on FC1. Therefore: is this a request to expand the emmendation list to include abbreviations such as Tommy, Dick and Harry, or can it be closed, @FreecenBren https://github.com/FreecenBren ?

— You are receiving this because you were mentioned.

Reply to this email directly, view it on GitHub https://github.com/FreeUKGen/FreeCENMigration/issues/289#issuecomment-404123693, or mute the thread https://github.com/notifications/unsubscribe-auth/ANC91pY_sTqBzbzCA3pLjnIiQi5Lc1Grks5uFdUCgaJpZM4OpdMg .

richpomfret commented 6 years ago

Closing - a separate story will be created for this type of new search as suggested by Brenda.