search

FreeUKGen / FreeUKGenealogy

Apache License 2.0
0 stars 0 forks source link

Width issue on mobile (Search page) #30

Open DeniseColbert opened 5 years ago

DeniseColbert commented 5 years ago

Screenshot_20180810-115529.png

ghost commented 5 years ago

@DeniseColbert For future reference, the following process will help to ensure we define and correct issues of this variety:

  1. Open Google Chrome
  2. Navigate to the page where the issue appears
  3. Press Ctrl+Shift+i to open Chrome Developer Tools
  4. Confirm that device emulation is toggled (it's the second icon from the left at the top of the debug console tray that looks like a phone over a rectangle and it should be blue to indicate device emulation is active)
  5. Use the dropdown menu or the gray bars at the top of the page panel to set the viewport width
  6. Go to the Menu icon (three dots) in the upper right-hand corner of the page panel and select Capture screenshot or Capture full size screenshot
  7. Attach the image with a concise description of the issue

(In this case I can see that the Search button is truncated but it was not immediately apparent what the issue was from the title)

DeniseColbert commented 5 years ago

Did that, but can't see where Capture screenshot is: image

(I guess screenshots through the DevTool are more helpful as you get some code info from it, but is the issue here that I didn't put enough description in the title?)

ghost commented 5 years ago

@DeniseColbert Ah my bad - forgot that the default dev panel layout puts the dev panel's options at the upper right-hand corner - try the three dots at the upper right-hand corner of the page display panel (next to the responsive/mobile emulation dropdown).

I guess screenshots through the DevTool are more helpful as you get some code info from it, but is the issue here that I didn't put enough description in the title?

Aye, basically I need to know what was expected and what happened instead of what was expected - if you can refer to the specific element I need to look at w/a screenshot, that's typically enough to put together a fix (but a description like "something is wrong" accompanying a screenshot means I have to hunt for that "something" and/or ask for clarification - otherwise I may end up working on something other than the intended bug).

DeniseColbert commented 5 years ago

Found the capture menu; thanks.

Right, that makes sense, I'll try to make sure I am more descriptive of the issue. So in this instance, would "Search button truncated on Search page on mobile" be sufficient, with a screen grab?

ghost commented 5 years ago

@DeniseColbert

So in this instance, would "Search button truncated on Search page on mobile" be sufficient, with a screen grab?

Yes, that description would leave no room for confusion on my part and the screenshot would allow me to quickly replicate the issue - bonus points if you include the viewport width (as this behavior can and will vary between widths with CSS media queries) e.g. "https://freeukgenealogy.org.uk/search - Search button truncated at 320px viewport width" + the screenshot provided would be the ideal description so far as I'm concerned.

DeniseColbert commented 5 years ago

Ok to remove gutter