Image placement / alignment doesn't work in 'multiple' mode

FreeUKGen / FreeUKGenealogy

Apache License 2.0

0 stars 0 forks source link

Image placement / alignment doesn't work in 'multiple' mode #56

Open DeniseColbert opened 5 years ago

DeniseColbert commented 5 years ago

I'm not sure 'multiple' mode is the correct name, I've circled it in the snip:

When selected (as here, on https://www.freeukgenealogy.org.uk/admin/entries/pages/2793-which-project) the 'left', 'centre' and 'right' toggle have no effect.

This will likely not be an issue in WP, but just logging it anyway.

ghost commented 5 years ago

@DeniseColbert Craft refers to this display type as "grid", which would suggest to me that it's intended to fill the horizontal display area - a review of the ul.gallery-thumbs HTML and CSS declarations associated with this display type shows forced left alignment within the grid (though the container element for the grid does reflect the specified alignment, it's overridden with text-align: left !important).

Given that this appears to be intended operation, I'd consider this a "no fix" issue with Craft.

DeniseColbert commented 5 years ago

No probs. Can we leave it open to make sure we get image alignment controls (and sizing if poss) right in WP?

ghost commented 5 years ago

@DeniseColbert I'd say that this issue stems from the Craft way of doing things (e.g. providing an alignment control for an element that overrides alignment) though you're welcome to leave open to confirm the effect can be accomplished in WordPress (can serve as reminder for me to provide instructions on how to use an appropriate Gutenberg block).

DeniseColbert commented 5 years ago

Yep, that's what I meant; thanks Gray.