Logo is muddy/ does not scale nicely

DeniseColbert commented 5 years ago

(both at 400%)

From @AlOneill : I can see what the the issue with the muddiness is caused by: the CSS is using data png instead of data svg

ghost commented 5 years ago

To confirm, you want to use https://www.freeukgenealogy.org.uk/images/svg/min/freeukgen.svg instead of the encoded PNG?

AlOneill commented 5 years ago

@arswright The Grunticon stylesheet loader is present in the head, but on both Chrome and Firefox, we are getting the data png styles. So the first question is does the data svg stylesheet exist and is it in the place expected by Grunticon?

I would not suggest putting the data svg image in the data png file: the separate files are there because of varying levels of browser support. There should also be a fallback file that uses ordinary png images: does that exist and is it where Grunticon expects? It should be served if, amongst other things, Javascript is turned off — have not tested that.

ghost commented 5 years ago

@AlOneill

So the first question is does the data svg stylesheet exist and is it in the place expected by Grunticon?

I'm not seeing any references to the SVG logo in any files associated with the repo (nor any database dumps).

grep -Rin 'freeukgen.svg' ./
Binary file ./.git/index matches

I would not suggest putting the data svg image in the data png file: the separate files are there because of varying levels of browser support. There should also be a fallback file that uses ordinary png images: does that exist and is it where Grunticon expects? It should be served if, amongst other things, Javascript is turned off — have not tested that.

Haven't had time to get grunt-grunticon running - encountering errors when attempting to install:

7733 warn grunt-sass@3.0.2 requires a peer of grunt@>=1 but none is installed. You must install peer dependencies yourself.
7734 warn FreeUKGenealogy-Website@1.0.0 No repository field.
7735 verbose stack Error: contextify@0.1.15 install: `node-gyp rebuild`
7735 verbose stack Exit status 1
7735 verbose stack     at EventEmitter.<anonymous> (/usr/lib/node_modules/npm/node_modules/npm-lifecycle/index.js:301:16)
7735 verbose stack     at EventEmitter.emit (events.js:198:13)
7735 verbose stack     at ChildProcess.<anonymous> (/usr/lib/node_modules/npm/node_modules/npm-lifecycle/lib/spawn.js:55:14)
7735 verbose stack     at ChildProcess.emit (events.js:198:13)
7735 verbose stack     at maybeClose (internal/child_process.js:982:16)
7735 verbose stack     at Process.ChildProcess._handle.onexit (internal/child_process.js:259:5)
7736 verbose pkgid contextify@0.1.15
7737 verbose cwd /mnt/archives/projects/site-uk.org.freeukgenealogy/public
7738 verbose Linux 4.4.0-151-generic
7739 verbose argv "/usr/bin/node" "/usr/bin/npm" "install" "grunt-grunticon"
7740 verbose node v10.16.0
7741 verbose npm  v6.9.0
7742 error code ELIFECYCLE
7743 error errno 1
7744 error contextify@0.1.15 install: `node-gyp rebuild`
7744 error Exit status 1
7745 error Failed at the contextify@0.1.15 install script.
7745 error This is probably not a problem with npm. There is likely additional logging output above.
7746 verbose exit [ 1, true ]

(Ultimately a moot point if this task is not prioritized over migration to WordPress CMS)

FreeUKGen / FreeUKGenealogy

Logo is muddy/ does not scale nicely #60