search

FreeUKGen / FreeUKGenealogyWP

For FUG WordPress migration work.
Apache License 2.0
0 stars 1 forks source link

Bring the above the fold area of Home page in line with Figma design #164

Open DeniseColbert opened 3 years ago

DeniseColbert commented 3 years ago

Top-left of Figma: https://www.figma.com/file/xys4PUozmu8NkDAvYhRgeQ/FreeUkGenealogy?node-id=642%3A1616

Image (in WP Media) requires shrinking to equal the watermark on e.g. FreeREG (top-right corner). Please document steps taken so that image can be changed out.

Drop-down becomes three CTA buttons, and all text moved to left of page.

hotbeverage2017 commented 3 years ago

I went to change the image and went into the Media to select the new honeycomb. The actual image does not need resizing it just needs resizing on the Elementor page, although I realize you want to get the graphic fixed to have even gaps in the honeycombs, but we can add the new one in when you get it.

In any case, once you select it as the background, in Elementor, check out the settings. It's no in the upper right corner. I do not allow it to repeat, because if you make it smaller and let it repeat, it fills the screen with it. I changed the size to Custom and just made it smaller until I thought it looked about like the size in Figma.

akhilpokle commented 3 years ago

In Figma,

  1. Extract the image.
  2. Use Inspect on the top right sidebar to get the exact size. Screenshot 2021-02-09 at 6 36 31 PM Screenshot 2021-02-09 at 6 36 47 PM
hotbeverage2017 commented 3 years ago

Thanks, but that's not quite how the WordPress plugin has us do that. We just drag it until it's the right size, basically, and there's a setting for which corner and replication and such. It's not quite the same as doing it directly in this manner. So,when we get the final image and I put it in there, someone will have to check to see if they agree that it's overlapping the other items in the right way. That's especially the case since the examples don't show the dropdowns overlaid on this.

On Tue, Feb 9, 2021 at 7:08 AM AKHIL POKLE notifications@github.com wrote:

In Figma,

  1. Extract the image.
  2. Use Inspect on the top right sidebar to get the exact size. [image: Screenshot 2021-02-09 at 6 36 31 PM] https://user-images.githubusercontent.com/17247801/107367922-e7a08f80-6b05-11eb-8e23-33c311c138ea.png [image: Screenshot 2021-02-09 at 6 36 47 PM] https://user-images.githubusercontent.com/17247801/107367931-ea02e980-6b05-11eb-9c5d-de6ecb7db6a4.png

— You are receiving this because you were assigned. Reply to this email directly, view it on GitHub https://github.com/FreeUKGen/FreeUKGenealogyWP/issues/164#issuecomment-775922600, or unsubscribe https://github.com/notifications/unsubscribe-auth/APNGM26MDJ4YRLNRCZLLSWLS6EXTXANCNFSM4XE42SCA .

hotbeverage2017 commented 3 years ago

Denise, f you look above where I responded to this, you'll see see my instructions on how to get this to fit on the page. If you change it in the Media then insert into Elementor, Elementor will just resize it, so you don't need to make any changes to the image size in there, at this time.

On Tue, Feb 9, 2021 at 8:45 AM Gloria hotbeverage2017@gmail.com wrote:

Thanks, but that's not quite how the WordPress plugin has us do that. We just drag it until it's the right size, basically, and there's a setting for which corner and replication and such. It's not quite the same as doing it directly in this manner. So,when we get the final image and I put it in there, someone will have to check to see if they agree that it's overlapping the other items in the right way. That's especially the case since the examples don't show the dropdowns overlaid on this.

On Tue, Feb 9, 2021 at 7:08 AM AKHIL POKLE notifications@github.com wrote:

In Figma,

  1. Extract the image.
  2. Use Inspect on the top right sidebar to get the exact size. [image: Screenshot 2021-02-09 at 6 36 31 PM] https://user-images.githubusercontent.com/17247801/107367922-e7a08f80-6b05-11eb-8e23-33c311c138ea.png [image: Screenshot 2021-02-09 at 6 36 47 PM] https://user-images.githubusercontent.com/17247801/107367931-ea02e980-6b05-11eb-9c5d-de6ecb7db6a4.png

— You are receiving this because you were assigned. Reply to this email directly, view it on GitHub https://github.com/FreeUKGen/FreeUKGenealogyWP/issues/164#issuecomment-775922600, or unsubscribe https://github.com/notifications/unsubscribe-auth/APNGM26MDJ4YRLNRCZLLSWLS6EXTXANCNFSM4XE42SCA .

johnshaw1000 commented 3 years ago

I think this is done, moving to review.

DeniseColbert commented 3 years ago

I need some help from devs for this- I added a CSS class and some code in a HTML block to make the class 'work' and, well... it doesn't!