search

FreeUKGen / MyopicVicar

MyopicVicar (short-sighted clergyman!) is an open-source genealogy record database and search engine. It powers the FreeREG database of parish registers, the FreeCEN database of census records, the next version of FreeBMD database of Civil Registration indexes and other Genealogical applications.
47 stars 16 forks source link

16 Review footer as solution to Main navigation broken at some screen widths #1004

Open AlOneill opened 8 years ago

AlOneill commented 8 years ago

Priority 16 (0 4 8 4)

At screen widths less than about 1100px, the social links are no longer visible -- not a big deal perhaps.

At screen widths between about 800 and 870px, the "Help" link is not visible -- this is a big deal, especially for a user on a device where the browser window cannot be resized.

Although the invisible links can be tabbed to, and will re-appear on-screen when in focus, this is unsatisfactory (and would remain so even after we make focus visually obvious) as it requires a fair degree of technical nous (or good luck!) to discover.

AlOneill commented 8 years ago

The basic issue is that we are trying to fit the proverbial quart into a pint pot. In other words, we have too many links in the main navigation, as it is currently set up.

The Search page is the worst because the "Transcriptions" link is longer than the "Search" link that replaces it on other pages.

There are a two obvious approaches:

(A third could be to use drop-down menu items, combining some current items: this would need to be pure CSS to be accessible and would be tricky to set up to be nicely responsive -- could turn out to be impractical. A fourth could be to allow the main nav to wrap to a second line -- tricky, may be impractical.)

Sherlock21 commented 8 years ago

If you opt for a solution that ends up generating wrap-around, then please don't let the SEARCH button go off the visible screen page bottom.

Captainkirkdawson commented 8 years ago

Is this a regression we did with the accessibility adjustments or was it always there

PatReynolds commented 8 years ago

I suggest we remove 'donate' from the menu, and have it as a separate item (button), either just underneath the title or just above the footer.

AlOneill commented 8 years ago

Kirk, the issue has been present for a while. It has not been affected by any of the accessibility changes.

The increase in the maximum width of a 'container' has allowed us to increase the number of main menu items, but at the expense of how much of that menu remains on-screen at less than maximum screen/window widths, especially on the Search page.

Pat, I am not clear where you mean by 'just underneath the title'. Putting a button near the top of a page will have an impact on the 'clutter' (if I may call it that!) at the top of a page, forcing the main content down further. On the face of it, I can't see how this could be done nicely.

There is a (small) link to 'Donate' in the footer already -- perhaps we need to re-think how the footer contents are presented, so that links to Donate and Volunteer are more prominent there. Neither of these are links that most visitors will use on a regular basis: so they probably do not belong in the main menu.

PatReynolds commented 8 years ago

Yes - review footer.

Captainkirkdawson commented 7 years ago

Need to respond to 24 management on charity status changes so should deal with other issues with footer at same time

AlOneill commented 7 years ago

The proposed new footer requires a number of markup and CSS changes. The image shows the revised footer (as discussed by Pat, Rich and Alison), plus a number of tentative text changes.

Because the changes are extensive, I see implementing a revised footer as part of the "last piece of the Accessibility jigsaw" -- updating application.html.erb, which provides the 'frame' for all pages. And because the other pieces of the jigsaw are not all in place, a full update would not be appropriate at this point.

footer-rev1 0

Captainkirkdawson commented 7 years ago

Not sure why Social links has the 2 links and then there are 2 links under project by ukgen. All 4 links refer to ukgen links all be it 2 are hosted internally and 2 externally . Would it not be better to have the 2 columns under a simple title of FreeUKGenealogy. Put the freeukGenealogy icon up with the other 2 icons

PatReynolds commented 7 years ago

I'm not sure what probem this is trying to solve.

The Free UK Genealogy icon is also giving the information that FreeREG is one of our projects. So maybe it needs to go at the top. Then 'our other projects, helping you to find your family history' then the two logos I wouldn't say 'Policies' are a 'Social Link', but yes, Blog (probably to be rechristened 'News') could go there.

Captainkirkdawson commented 7 years ago

My comments related to the proposed new footer appearing unbalanced at least in my mind balance

AlOneill commented 7 years ago

The Blog and Policies links go to the FreeUK Gen site: the Social links don't. Two different animals. The links section would have a lot of 'air' with only 2 columns. (The current 2 columns are balanced by the logo.)

As ever, 'balance' is in the eye of the beholder. Putting all 3 icons together would achieve a kind of balance, but the footer would be deeper overall and top-heavy. Balance and symmetry are not necessarily synonymous.

Captainkirkdawson commented 7 years ago

I agree much of this is personal preference. To my eye having 2 links under the freeukgen icon is disturbing. 3 columns of links and then the icon would be more balanced for me

PatReynolds commented 7 years ago

Icon headed column in the middle?

Pat Reynolds Executive Director, Free UK Genealogy

On 28 Dec 2016 17:26, "Kirk Dawson" notifications@github.com wrote:

I agree much of this is personal preference. To my eye having 2 links under the freeukgen icon is disturbing. 3 columns of links and then the icon would be more balanced for me

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/FreeUKGen/MyopicVicar/issues/1004#issuecomment-269509988, or mute the thread https://github.com/notifications/unsubscribe-auth/AGC5BsFWmZkXIC1F0e7edeXpsfnLX6Xhks5rMpvEgaJpZM4Kpw4Y .

AlOneill commented 7 years ago

Thanks for the comments -- two alternatives for your consideration ...

Version 2

footer-rev1 2

Version 3

footer-rev1 3

edickens commented 7 years ago

I prefer Version 3.  E

  On 29/12/2016 16:16, AlOneill wrote:

  Thanks for the comments -- two alternatives for your
    consideration ...
Captainkirkdawson commented 7 years ago

Personally I would like to see a variation of version 3 that had 4 "columns" in the footer; the 3 text ones and 1 occupied by the freeukgen icon

Kirk Dawson 5220 Riverside Drive Fairmont Hot Springs, B.C. V0B 1L1

On 29 December 2016 at 09:22, Eric Dickens notifications@github.com wrote:

I prefer Version 3. E

On 29/12/2016 16:16, AlOneill wrote:

Thanks for the comments -- two alternatives for your consideration ... Version 2

Version 3

{"api_version":"1.0","publisher":{"api_key":" 05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity": {"external_key":"github/FreeUKGen/MyopicVicar","title" :"FreeUKGen/MyopicVicar","subtitle":"GitHub repository","main_image_url":" https://cloud.githubusercontent.com/assets/143418/17495839/a5054eac-5d88- 11e6-95fc-7290892c7bb5.png","avatar_image_url":"https:// cloud.githubusercontent.com/assets/143418/15842166/ 7c72db34-2c0b-11e6-9aed-b52498112777.png","action":{"name":"Open in GitHub","url":"https://github.com/FreeUKGen/MyopicVicar"}}," updates":{"snippets":[{"icon":"PERSON","message":"@AlOneill in #1004: Thanks for the comments -- two alternatives for your consideration ...\r\n\r\nVersion 2\r\n\r\nfooter-rev1 2\r\n\r\nVersion 3\r\n\r\nfooter-rev1 3\r\n"}],"action":{"name":"View Issue","url":"https://github. com/FreeUKGen/MyopicVicar/issues/1004#issuecomment-269653095"}}}

— You are receiving this because you were assigned. Reply to this email directly, view it on GitHub https://github.com/FreeUKGen/MyopicVicar/issues/1004#issuecomment-269654061, or mute the thread https://github.com/notifications/unsubscribe-auth/ACvdRtwr3XZzLqoU9p0TagaBI9qv0Amkks5rM95KgaJpZM4Kpw4Y .

Captainkirkdawson commented 7 years ago

CIO status and # added to footer

PatReynolds commented 7 years ago

include donate button

Captainkirkdawson commented 7 years ago

@AlOneill are we ready to test this on test3?

AlOneill commented 7 years ago

In short, no. Do not know what "donate button" is intended to look like: our standard button or something else? Have not begun changes to erb file.

Captainkirkdawson commented 7 years ago

The donate is to go in the search results page. I was referring to completion of the work as of 3 weeks ago. Understand the erb changes are to come

richpomfret commented 7 years ago

David to create donate button. Review still in-progress.

PatReynolds commented 7 years ago

@AlOneill to consider possible changes to Free UK Genealogy logo for use against this background.

richpomfret commented 7 years ago

Let's look at creating a mock-up for this (considering the other story relating to site stats).

richpomfret commented 7 years ago

Stats are STAYING. Alison to take a look/review.

PatReynolds commented 7 years ago

Footer also needs to be able to handle 'bouquets' in due course (see #1195). Sorry @AlOneill !

Captainkirkdawson commented 6 years ago

@AlOneill is this still open and a requirement

PatReynolds commented 3 years ago

I believe this is resolved on systemwide, so moved to Needs Review