search

FreeUKGen / MyopicVicar

MyopicVicar (short-sighted clergyman!) is an open-source genealogy record database and search engine. It powers the FreeREG database of parish registers, the FreeCEN database of census records, the next version of FreeBMD database of Civil Registration indexes and other Genealogical applications.
44 stars 15 forks source link

Sidebars below My Heritage ad is too far down the page #2603

Closed DeniseColbert closed 1 year ago

DeniseColbert commented 1 year ago

image.png

https://www.freereg.org.uk/cms/about

DeniseColbert commented 1 year ago

@Vino-S we think the ad should be the bottom-most of all sidebar blocks?

AlOneill commented 1 year ago

@DeniseColbert @Vino-S I'm pretty sure that I was asked to place "More about FreeREG" and the content below it at the bottom of the sidebar. So nothing has moved or been moved by the Ad.

DeniseColbert commented 1 year ago

@PatReynoldsFUG is this the way we wanted it?

DeniseColbert commented 1 year ago

Scrum thinks this should be further up the page.

AlOneill commented 1 year ago

Sorry, Scrum, but "further up the page" is rather imprecise — I do not know how to interpret it. There are two things to consider here: the visual placement and its position in the source order which determines when a mobile user or a screen reader user will see or hear it. After what? Before what? Thank you!

DeniseColbert commented 1 year ago

Sorry Alison; directly below the My Heritage ad, visually. In the source order, I think it should come after the text in the body or after the sidebar links, whichever is best for keyboard-only users.

AlOneill commented 1 year ago

For sighted keyboard-only users there needs to be a correlation between what a user sees (at all screen widths) and the tabbing order (i.e. the source order). A screen reader user has ways of making sense of the page other than by hearing it in strict source order — only a raw beginner would attempt to take in the whole page in source order. It sounds as if you want the page put back to how it started. Fair enough. That is what I'll do. I'll post here when it is done — the current page has to be unravelled, as it were.

AlOneill commented 1 year ago

The sidebar content below the My Heritage ad has been moved as per the Scrum's request of 5 days ago. In other words it has been optimised for sighted keyboard-only users rather than for screen reader users. This seems the best solution for the reasons given 4 days ago.

It is placed as best as I can do for the current page contents but will need review if and when the content of either column changes including changes to the height of the My Heritage advert.

AlOneill commented 1 year ago

The draft page for review is https://test3.freereg.org.uk/cms/draft-about

DeniseColbert commented 1 year ago

Thanks @AlOneill ready to go live now

DeniseColbert commented 1 year ago

I think this is deployed, reopen if not