Jc/refactor assets pipeline

FreeUKGen / MyopicVicar

MyopicVicar (short-sighted clergyman!) is an open-source genealogy record database and search engine. It powers the FreeREG database of parish registers, the FreeCEN database of census records, the next version of FreeBMD database of Civil Registration indexes and other Genealogical applications.

44 stars 15 forks source link

Jc/refactor assets pipeline #2666

Closed jayto581 closed 10 months ago

jayto581 commented 1 year ago

remove redundant/duplicate code
standardise stylesheet_link_tag and javascript_include_tag command format
reorganise config.assets setting
add additional documentation note
reorganise setting code to follow Rails 5.x convention

jayto581 commented 1 year ago

Should any reference to the prebid.ads.js script be removed?

I cannot find this file anywhere. It is called in the app/views/layouts/application.html.erb

jayto581 commented 1 year ago

systemwide issue number 286

jayto581 commented 1 year ago

@Vino-S I found the prebid_ads.js file It is currently in MyopicVicar\public_site_specific\common_files

Should this file be move into the assets pipeline in MyopicVicar\app\assets\javascripts

jayto581 commented 10 months ago

PR out of date, Update and resubmit