Closed benwbrum closed 10 years ago
Eric B writes:
If one enters a search from date that is AFTER the search To date, then the request is accepted but nil result ensues.
I feel the request should generate a REJECTED page highlighting [or just saying] what's wrong with the request logic.
I respond:
Regarding #1, I think that the best behavior for someone entering "From: 1690, To: 1688" is to perform a search from 1688 to 1690 instead and display at the top of their search results a message similar to Google's "Showing results for 'epigraphy' instead of 'epigraphi'" explaining what we did, rather than rejecting their query outright. Opinions?
Ben
I agree with your suggestion
Kirk Dawson Fairmont Hot Springs, B.C. V0B 1L1
On Sat, Jul 27, 2013 at 9:17 PM, Ben W. Brumfield notifications@github.comwrote:
I respond:
Regarding #1 https://github.com/FreeUKGen/MyopicVicar/issues/1, I think that the best behavior for someone entering "From: 1690, To: 1688" is to perform a search from 1688 to 1690 instead and display at the top of their search results a message similar to Google's "Showing results for 'epigraphy' instead of 'epigraphi'" explaining what we did, rather than rejecting their query outright. Opinions?
— Reply to this email directly or view it on GitHubhttps://github.com/FreeUKGen/MyopicVicar/issues/35#issuecomment-21676452 .
Currently the search query for provides no validation at all on search date order. As a result, researchers can search for impossible ranges.