search

FreeUKGen / Systemwide

repository for issues that affect all systems within the Free UK Gen portfolio
0 stars 0 forks source link

Review links in Footer #250

Open DeniseColbert opened 2 years ago

DeniseColbert commented 2 years ago

It's a bit cluttered, what we remove/place elsewhere so that we can unclutter and put the Accessibility Statement in.

DeniseColbert commented 2 years ago

Balance of text to other projects. Review Royal Mail footer for inspiration. @DeniseColbert to take a look

DeniseColbert commented 2 years ago

Capture

DeniseColbert commented 2 years ago

@AlOneill social icons don't have links on Royal Mail footer, or was it something else they did well that I should be looking at?

PatReynolds commented 2 years ago

image.png

Nb text is not hyperlinked. Icons have tool tip saying 'RNIB on Twitter' (etc.)

PatReynolds commented 2 years ago

Not providing information to those not using screen readers about the icons. Chrome, Edge, Safari, Firefox all show the destination url of links (Safari also says if it opens in a new tab) - presume users needing this information will use a browser that provides it.

Add link to Accessibility Statement into left-hand panel panel

Move make a donation moves to bottom

Need to check how Joseph has set up.

DeniseColbert commented 2 years ago

@Vino-S the SCSS needs changing to remove the space after the third list item. A (slightly) smaller space can be added inline after Accessibility Statement.

I.e.

Useful Links

Cookie Policy Privacy Notice Terms & Conditions Accessibility Statement

Contact Us News about Free UK Genealogy Make a donation to cover our operating costs

(Could you also change the "and" in Terms and Conditions to an ampersand please? (i.e. "&"))

DeniseColbert commented 2 years ago

@vino could you also make ALL links in the footer open in the same tab please?

DeniseColbert commented 6 months ago

@AlOneill please could you review this story and let us know if there are still any issues with the footer?

AlOneill commented 6 months ago

@DeniseColbert There is no Accessibility statement link — do you want one? I think it would be a good idea as the footer is typically where people with disabilities will look before deciding whether to stay on the site or go elsewhere. (This might require a review of the CSS re vertical spacing.)

Nothing else jumped out at me.

jayto581 commented 4 months ago

Do we remove a link or add another link? If we add another link the Statistics box (on the right) may need to be enlarged to balance the footer. image

Accessibility https://www.freeukgenealogy.org.uk/about/pages/accessibility/

jayto581 commented 4 months ago

Revised mock up. snag-0004b

Accessibility https://www.freereg.org.uk/cms/about/accessibility-statement https://www.freecen.org.uk/cms/about/accessibility-statement https://www.freebmd.org.uk/cms/about/accessibility-statement

DeniseColbert commented 3 months ago

e.g. image

jayto581 commented 3 months ago

@DeniseColbert A working mock up of the footer with the Accessibility statement link is available at the following site for review: https://jayto581.github.io/FUG_Demo/index2024-05-05.html

DeniseColbert commented 3 months ago

@AlOneill do you have any thoughts on Joseph's mock up in terms of accessibility?

AlOneill commented 3 months ago

Generally very good, however I do have some thoughts:

  1. there are 2 links to FreeUKGen News: one in the text listing and one as a social media link — do we want both or is two confusing?

  2. why do 'Cookie policy' and 'Privacy notice' share a line (and share a list item which wold make no sense if you could not see the list)? Using bars to separate the two looks odd in that context. Surely the left and right boxes simply scale to the height of the taller? Do we want a big gap between the groups of list items? The CSS can be changed to eliminate it. BTW non-breaking spaces, either side of the bars, are a terrible way to attempt to control spacing! Padding and margin are the correct way to determine spacing

  3. it seems like 'Other FreeUKGenealogy Projects' is also a heading but it is not marked up as such (suggest level 2 would be appropriate, with the same styling as currently rather than styled to match 'Useful links')

  4. ditto for 'Follow us' — headings help screen reader users to find content as they can summon up a list of all the headings on a page and use that list to navigate — our footer has a lot in it, more than many, and so it would take time to explore the whole footer without helpful headings

jayto581 commented 3 months ago

@AlOneill Thanks for the feedback.

I have added all your suggestions to the mockup. https://jayto581.github.io/FUG_Demo/

image

We will discuss the FreeUKGen News suggestion at the next sprint.

AlOneill commented 3 months ago

@jayto581 Looks good! Thank you. I'll be interested to see the Scrum's decision about the News link. An odd number of social media links (as now) is more aesthetically appealing than an even number would be, yet the text link has maybe more impact for most users than a symbol. We shall see! (I hope it is unnecessary for me to say this, but please, please do not decide on a title attribute for the symbols. We have been there and they are not Accessible for anyone who does not use a pointing device, including mobile phone users! Text content should be visible all the time, for every user.)

DeniseColbert commented 2 months ago

Decision to remove RSS icon and Twitter (no longer active there) and slightly increase spacing/padding between the three remaining icons

jayto581 commented 2 months ago

I have made the changes to the mockup. https://jayto581.github.io/FUG_Demo/ image

AlOneill commented 2 months ago

@jayto581 This is a relatively minor quibble (!) but I find it distracting (perhaps clumsy is a good description?) that the left and right padding of the icons is not the same. It does not look equal (balanced) when an icon is in focus. Could you fix that please?

jayto581 commented 2 months ago

fixed. oops, good catch.

jayto581 commented 2 months ago

See test3 for updates https://test3.freereg.org.uk/cms/refinery/login

Vino-S commented 2 months ago

Hi @AlOneill , Updated Joseph's changes on test3(FreeREG). Could you have a look, please

AlOneill commented 2 months ago

@jayto581 Thank you for fixing the left and right padding.

Curiously, althougth the values are now equal, visually (Firefox on Mac) they do not look the same: the right padding looks wider than the left. Maybe it's because the icons are not a whole number of pixels wide, or the whitespace introduced by the markup or something similar. Anyway, we have done our best to fix it, so please do not spend any more time on this.

DeniseColbert commented 1 month ago

Ready for deployment: thanks everyone!

DeniseColbert commented 1 month ago

@jayto581 to deploy

DeniseColbert commented 2 weeks ago

@Vino-S will investigate stats issue and let @jayto581 know to try to merge again.