search

FreeUKGen / Systemwide

repository for issues that affect all systems within the Free UK Gen portfolio
0 stars 0 forks source link

All adverts appearing incorrectly sized #59

Closed richpomfret closed 4 years ago

richpomfret commented 5 years ago

Across each project, including test sites. May well be 'bad' settings in Adsense made by external advert team. They are apparently 'responsive', but I wonder if our code actually supports that or if we previously had fixed resolution settings?

richpomfret commented 5 years ago

@Vino-S do keep in mind that we have been advised to switch across to fixed adverts and not use responsive. There is an additional issue (will need a new story) for the cookie acceptance message no longer appearing on FR too.

@Captainkirkdawson I am otherwise happy to see the fix deployed for the size issue. We can wait and see in terms of issues with adverts appearing (or not) on production.

Vino-S commented 5 years ago

Ah. Just noticed Kirk had fixed the issue in test3. :)

Vino-S commented 5 years ago

@richpomfret Is the issue on live website(cookie consent banner)?

richpomfret commented 5 years ago

@Vino-S the cookie consent banner DOES appear ok on live/production site.

Captainkirkdawson commented 5 years ago

I merged master into issue_59. I then merged issue_59 into systemwide_59. Ran tests on test3. All working well on test3. ads deploying and changing when switching personalized. Correct size! So merged into master and deployed to test3 sites. REG works fine in all aspects. Now the kicker. Cen does not initially display ads. Removed cookies (all) to force cookie acceptance. All adverts appear correct size. cookie policy shows that personalized and analytics are set. Changed to reject personalized and general advert appears while the cookie page is showing. Switch to search/database coverage. No advert. Switch to help and non personalized advert appears . That is your challenge for today. Left test3 running master. So we have made 100% progress on REG and regressed partially on CEN I deployed to brazza and both reg and cen worked as they should. Then deployed to all servers. Now Cen works as it should. BUT Reg does not appear to deliver adverts. It appears as though (adsbygoogle=window.adsbygoogle||[]).pauseAdRequests=1; is not being cleared.

PatReynolds commented 5 years ago

Thanks to all for your continued wrangling. test3. and live on FreeREG now delivering fine. test2 is showing the dummy 'banner ad'.

PatReynolds commented 4 years ago

FYI: Adsense announced last week what they had done at the end of August: https://support.google.com/adsense/answer/9467650?hl=en-GB (just saw this today).

Captainkirkdawson commented 4 years ago

How nice of them!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!