search

FreeUKGen / Systemwide

repository for issues that affect all systems within the Free UK Gen portfolio
0 stars 0 forks source link

Change navigation bar #90

Open Captainkirkdawson opened 4 years ago

Captainkirkdawson commented 4 years ago

The FreeBMD2 specifications call for the integration of the Project logo in the menu bar

Captainkirkdawson commented 4 years ago

Being done as part of 103

AlOneill commented 4 years ago

@PatReynolds @neslihanu Removing the excess space from the project logos has changed the visual balance of the nav bar contents. I suggest we do not centre the logos in their white space, but put more space on their right. It looks better (to me), perhaps because it echoes the left-right set-up of the nav bar and makes the logo appear less static (stuck) and more dynamic.

FreeBMD_Header_2_31.png

The asymmetry also makes placing the narrower CEN and REG logos simpler

FreeREG_Header_2_31.png

What do you each think?

Captainkirkdawson commented 4 years ago

I had thought that the links in the nav bar would have been left positioned in the second part rather than right positioned I would also have preferred to see a bigger stub before the logo. It seems far too small and makes the total bar seem unbalanced

AlOneill commented 4 years ago

@Captainkirkdawson I have not quite captured the whole width of the nav bar in the image above: the left edge is inadvertently cropped a little in the image. It is as wide as the blue that extends beyond "Help", i.e. it matches the content container. If the boundary is pulled right, what will it align with? If it aligns with nothing else, it will not look right/good.

On a wider page, the blue/white boundary will continue to match the content container, like this:

FreeREG_Header_2_3_wide

The right-alignment of the text part of the menu is how I remember Neslihan's design as it was previously implemented on BMD2 test2.

Captainkirkdawson commented 4 years ago

Ah much better. No further comment

PatReynolds commented 4 years ago

Agreed, looks very good!

DeniseColbert commented 4 years ago

@AlOneill the menu text was right-aligned in test 2 but wasn't in the original design, hence #161 (which has been closed, presuming as it had been fixed, but just headed there to check and the whole header seems to have reverted to the original form!) @PatReynolds can you remember if you closed as it was fixed, or for another reason? You closed #160 and #162 that day, and #162 is still broken on current version of test 2. #160 is pretty much the FreeBMD2 version of this story.

Captainkirkdawson commented 4 years ago

imo it should be left aligned with the first element the standard list width from the edge just like all items are the same distance from the previous one. ie the logo is really just like an item in the list

neslihanu commented 4 years ago

For me, it looks good but I just noticed that the color code of the nav bar and the tabs on the menu is different than our designs. Did I miss something ? For example, why we have "search" tab on the menu ?

Captainkirkdawson commented 4 years ago

@neslihanu suspect you may not have seen some of the systemwide stories. The colours being used are those in systemwide #71 https://app.zenhub.com/workspaces/system-wide-code-changes-5ccc857f10a32d7d637c8f48/issues/freeukgen/systemwide/71 These colours were from our original work on accessibility. The nav links will vary according to the page that is being displayed. eg Search is not a link on the search page. The nav link names are now consistent across all applications