search

FreederTeam / Freeder

An easy-to-use free feed reader
Other
5 stars 1 forks source link

Aspect ratio of images is not kept #48

Closed Phyks closed 9 years ago

Phyks commented 9 years ago

Images fit well the page width, but their aspect ratio ils not preserved, at least in Firefox for Android.

I don't remember such problem on Firefox for PC so maybe it's a mobile issue.

tmos commented 9 years ago

Don't you remember that we had exactly the same issue in Greeder ? :D

Phyks commented 9 years ago

I don't remember :/ But the problem seems to be only with Firefox on mobile, and not on PC, I think (the height: auto tip does not seem to work).

tmos commented 9 years ago

Avec :

max-width:100%;
height:auto;

Ça ne fonctionne pas ?

Phyks commented 9 years ago

Je confirme que ce bout de CSS y est déjà.

J'ai retesté, mais j'arrive plus à reproduire… Je clos et on rouvre si on le voit de nouveau. Mais c'est sûrement un bug dans firefox mobile du coup.

Phyks commented 9 years ago

I managed to reproduce on the feed from TheBigPicture. The problem was that the img element in the feed had style directly on the element, imposing width and height, which was overwriting the height: auto; directive.

I added some !important in the CSS of images in articles to overwrite this behaviour. @tmos : Feel free to update it if it's not a good solution.

marienfressinaud commented 9 years ago

Consider to remove style="…" attributes from the feed instead of using !important in the CSS. It is cleaner and more reliable ;)

eliemichel commented 9 years ago

:+1:

Phyks commented 9 years ago

:+1: :p