C# 8.0 warns that fields can only contain null if they are explicitly marked as potentially doing so (or they are using the implicit type, var, which is permitted to be a nullable type). This enables the nullability-annotated interpretation of the code (that all types without an explicit ? suffix are nonnull) and fixes places where this didn't work with existing code, typically by marking nullable fields as nullable.
As of time of writing, unit tests are broken, but that's not due to this PR, that is preexisting.
Do not submit until the base (that cleans up a bunch of other, unrelated warnings) is in.
AdamNorberg
commented
2 years ago
C# 8.0 warns that fields can only contain null if they are explicitly marked as potentially doing so (or they are using the implicit type,
var, which is permitted to be a nullable type). This enables the nullability-annotated interpretation of the code (that all types without an explicit?suffix are nonnull) and fixes places where this didn't work with existing code, typically by marking nullable fields as nullable.As of time of writing, unit tests are broken, but that's not due to this PR, that is preexisting.
Do not submit until the base (that cleans up a bunch of other, unrelated warnings) is in.